Skip to content

Birmingham | 26-SDC-Mar | Chioma Okeke | Sprint 2 | Shell Pipelines#404

Open
JanefrancessC wants to merge 6 commits into
CodeYourFuture:mainfrom
JanefrancessC:shell-pipelines
Open

Birmingham | 26-SDC-Mar | Chioma Okeke | Sprint 2 | Shell Pipelines#404
JanefrancessC wants to merge 6 commits into
CodeYourFuture:mainfrom
JanefrancessC:shell-pipelines

Conversation

@JanefrancessC

@JanefrancessC JanefrancessC commented Mar 20, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed the exercises /shell-pipelines.

@JanefrancessC JanefrancessC added 🦑 Size Large 4-8 hours 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Tools The name of the module. labels Mar 20, 2026
SlideGauge
SlideGauge reviewed May 3, 2026
View reviewed changes

@SlideGauge SlideGauge left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add trailing new lines to all the scripts? Check your settings of your editor, it should help

Comment thread shell-pipelines/sort-uniq-head-tail/script-03.sh Outdated
Comment thread shell-pipelines/sort-uniq-head-tail/script-02.sh Outdated
Comment thread shell-pipelines/sort-uniq-head-tail/script-04.sh Outdated
Comment thread shell-pipelines/sort-uniq-head-tail/script-03.sh Outdated
Comment thread shell-pipelines/sort-uniq-head-tail/script-07.sh Outdated
Comment thread shell-pipelines/ls-grep/script-03.sh Outdated
@SlideGauge

SlideGauge commented May 3, 2026

Copy link
Copy Markdown

Overall good job, could you address my notes please and I will accept the work?

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 3, 2026
@JanefrancessC

JanefrancessC commented May 15, 2026

Copy link
Copy Markdown
Author

Could you add trailing new lines to all the scripts? Check your settings of your editor, it should help

This is mostly from my prettier formatter, but I have addressed that now.

@JanefrancessC JanefrancessC added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@SlideGauge SlideGauge SlideGauge left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Tools The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🦑 Size Large 4-8 hours 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JanefrancessC @SlideGauge