Fix style conflict#813
Merged
Merged
Conversation
onora-hbl
previously approved these changes
Jun 25, 2026
onora-hbl
left a comment
onora-hbl
left a comment
Contributor
There was a problem hiding this comment.
LGTM but it doesn't compile
instead of injecting it in the head and duplicating it in the shadow dom except for font-faces, that need to be injected in the page head
CGNonofr
force-pushed
the
fix-css-conflict-shadow-dom
branch
from
d9efc0f to
652df7a
Compare
Contributor
Author
It was just an unused import, cleaned & amended |
onora-hbl
approved these changes
Jun 25, 2026
|
🎉 This PR is included in version 34.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By only injecting the styles in the shadow dom
Basically, when using the sandbox+shadow dom mode AND a regular editor in the same page, both vscode instances are conflicting on the styles
Currently, dynamic styles are injected into the document head, and then synchronized with the shadow dom.
Now, the dynamic styles are only injected in the shadow dom, except for font-faces that are extracted and injected into the page head, just like what is already done here for static stylesheets