Add game tests for reverting mob head progression in the Purifier - #1259
Merged
Merged
Conversation
Covers the Wither Skeleton Skull -> Creeper Head -> Zombie Head -> Skeleton Skull revert chain, and guards that heads without a previous progression step are left untouched. These tests only pass once the implementation is upmerged from master-1.20-lts. Closes #1258 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DwM8cKrtoseKe4UBtH6NLL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds game tests only, for the mob head revert feature from #1258.
These tests fail on this branch until the implementation is upmerged from
master-1.20-lts. That is intentional: the implementation lives in 2ac3fbf onmaster-1.20-lts, and these tests are here so the upmerge is covered the moment it lands. CI on this PR will be red until then.Tests added to
GameTestsPurifiertestPurifierMobHeadDowngrade— one Purifier per progression step, each given a head and a full tank of blood, asserting the Wither Skeleton Skull → Creeper Head → Zombie Head → Skeleton Skull revert chain and that the blood is consumed.testPurifierMobHeadDowngradeEndOfProgression— Skeleton Skull, Player Head and Dragon Head are left untouched and their blood is not consumed, guarding against the action over-reaching past the end of the chain.Verification
Run locally against a temporary port of the
master-1.20-ltsimplementation:./gradlew runGameTestServer→ all 81 tests pass.testpurifiermobheaddowngradefails withExpected minecraft:wither_skeleton_skull to be purified into minecraft:creeper_head, but got minecraft:wither_skeleton_skull, confirming the test is not vacuously passing.The temporary implementation port was not committed; this branch contains the test file change only.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DwM8cKrtoseKe4UBtH6NLL
Generated by Claude Code