Update Common Capabilities to 2.11.5-373 - #235
Merged
rubensworks merged 1 commit intoSep 8, 2026
Merged
Conversation
This carries the fix for extraction from slots larger than a vanilla stack, which previously pulled a single item per item handler call. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ACuxaa5QeiZ8mVsEQtwSq1
rubensworks
deleted the
deps/commoncapabilities-large-slot-extraction
branch
September 8, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
commoncapabilities_versionfrom2.11.5-363to2.11.5-373, the first release carrying CyclopsMC/CommonCapabilities#49 (storageExtractItemno longer taking its maximum stack size fromItemStack.EMPTY, which reports 1 since the component rewrite).The point of this PR is to run Integrated Crafting's game tests against that change, since extraction from storage is on the hot path for every crafting job and the fix alters how every
extractItemcall is sized.Result
All 76 game tests pass. No changes were needed anywhere else.
The run log confirms
commoncapabilities-1.21.1-neoforge-2.11.5-373-deobf.jarwas the jar loaded, and I checked the published jar's bytecode before pinning it:storageExtractItemnow callsgetStackInSlot(slot).getMaxStackSize()rather thanItemStack.EMPTY.getMaxStackSize().Validation
./gradlew buildpasses./gradlew runGameTestServer --rerunpasses, 76 game testsUsed
--rerundeliberately: Gradle otherwise marks the run taskUP-TO-DATEand reports success without executing anything.One thing worth knowing
2.11.5-368was never published, because that run failed at Deploy to CurseForge and the Deploy to Maven step is downstream of it, so it got skipped. That is why the previous pin was still-363rather than something more recent. Nothing to do here, but it means a red Common Capabilities master silently stops publishing to Maven.🤖 Generated with Claude Code
https://claude.ai/code/session_01ACuxaa5QeiZ8mVsEQtwSq1
Generated by Claude Code