You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The _logs attribute of the above is a set of instances of LogData, which subclasses dict and adds a __hash__ method. However, it is annotated as set[dict[str, Any]]. This is incorrect, because dict's are not necessarily hashable and cannot be used as items in a container such as set. This PR changes it to set[LogData].
May I know how I would sign my commits on the web interface, since that appears to be required?
Right, that's a good question. To be honest, I don't know, but it must be documented somewhere in GitHub docs. (I thought GitHub commits created through the web interface were automatically signed...)
You will need to configure commit signing in GitHub and your local Git configuration, but yes, once you've done that, cherry-picking should add signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
_logsattribute of the above is a set of instances ofLogData, which subclassesdictand adds a__hash__method. However, it is annotated asset[dict[str, Any]]. This is incorrect, becausedict's are not necessarily hashable and cannot be used as items in a container such asset. This PR changes it toset[LogData].Additional Notes
#18043 again.