Skip to content

chore: annotation for ddtrace.internal.telemetry.writer.TelemetryWriter#18680

Open
jonathandung wants to merge 2 commits into
DataDog:mainfrom
jonathandung:patch-1
Open

chore: annotation for ddtrace.internal.telemetry.writer.TelemetryWriter#18680
jonathandung wants to merge 2 commits into
DataDog:mainfrom
jonathandung:patch-1

Conversation

@jonathandung

@jonathandung jonathandung commented Jun 21, 2026

Copy link
Copy Markdown

Description

The _logs attribute of the above is a set of instances of LogData, which subclasses dict and adds a __hash__ method. However, it is annotated as set[dict[str, Any]]. This is incorrect, because dict's are not necessarily hashable and cannot be used as items in a container such as set. This PR changes it to set[LogData].

Additional Notes

#18043 again.

@jonathandung jonathandung requested a review from a team as a code owner June 21, 2026 03:41
@datadog-dd-trace-py-rkomorn

This comment has been minimized.

@KowalskiThomas KowalskiThomas added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 22, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jun 22, 2026

Copy link
Copy Markdown

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

System Tests | download-s3-wheels   View in Datadog   GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 954db4b | Docs | Datadog PR Page | Give us feedback!

Comment thread ddtrace/internal/telemetry/writer.py

@KowalskiThomas KowalskiThomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my question, the changes look good to me! 💯

@jonathandung

Copy link
Copy Markdown
Author

May I know how I would sign my commits on the web interface, since that appears to be required? Or do I have to clone the repo locally? Thanks

@KowalskiThomas

KowalskiThomas commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

May I know how I would sign my commits on the web interface, since that appears to be required?

Right, that's a good question. To be honest, I don't know, but it must be documented somewhere in GitHub docs. (I thought GitHub commits created through the web interface were automatically signed...)

@jonathandung

jonathandung commented Jun 23, 2026

Copy link
Copy Markdown
Author

If I clone the repo, cherry-pick to a temporary branch and force-push it to the base, can I make the commits signed?

@KowalskiThomas

Copy link
Copy Markdown
Contributor

You will need to configure commit signing in GitHub and your local Git configuration, but yes, once you've done that, cherry-picking should add signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants