fix(tracing): missing svc_src:m case#18694
Conversation
…vice names on creation and later have service name overridden
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2e8e0c339
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if service_source: | ||
| span.set_tag(_SERVICE_SOURCE, service_source) | ||
| else: | ||
| service_source = "m" |
There was a problem hiding this comment.
Update snapshots for the new svc_src tag
When this fallback is hit for integrations that set a configured service after creating the span, it now adds meta._dd.svc_src: m to payloads, but the commit does not update the affected snapshots. For example, tests/contrib/graphql/test_graphql.py::test_span_schematization with DD_SERVICE=my-service and Kafka's test_service_override_config both exercise this path and their checked-in snapshots currently omit _dd.svc_src, so snapshot CI will fail unless those expected files are updated or the tag is intentionally ignored.
Useful? React with 👍 / 👎.
Codeowners resolved as |
provide fallback svc_src for the case where root spans are not given service names on creation and later have service name overridden.