Skip to content

fix(tracing): missing svc_src:m case#18694

Draft
emmettbutler wants to merge 7 commits into
mainfrom
emmett.butler/extra-m
Draft

fix(tracing): missing svc_src:m case#18694
emmettbutler wants to merge 7 commits into
mainfrom
emmett.butler/extra-m

Conversation

@emmettbutler

Copy link
Copy Markdown
Collaborator

provide fallback svc_src for the case where root spans are not given service names on creation and later have service name overridden.

…vice names on creation and later have service name overridden
@emmettbutler emmettbutler requested review from a team as code owners June 22, 2026 17:40
@emmettbutler emmettbutler requested review from juanjux and wconti27 June 22, 2026 17:40
@emmettbutler emmettbutler marked this pull request as draft June 22, 2026 17:40
@datadog-dd-trace-py-rkomorn

datadog-dd-trace-py-rkomorn Bot commented Jun 22, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 1 Pipeline job failed

Changelog | Validate changelog   View in Datadog   GitHub Actions

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 07056b7 | Docs | Give us feedback!

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 12 Pipeline jobs failed

Changelog | Validate changelog   View in Datadog   GitHub Actions

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64, 1]   View in Datadog   GitLab

View all 12 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 2 jobs - 0 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 07056b7 | Docs | Datadog PR Page | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2e8e0c339

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

if service_source:
span.set_tag(_SERVICE_SOURCE, service_source)
else:
service_source = "m"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update snapshots for the new svc_src tag

When this fallback is hit for integrations that set a configured service after creating the span, it now adds meta._dd.svc_src: m to payloads, but the commit does not update the affected snapshots. For example, tests/contrib/graphql/test_graphql.py::test_span_schematization with DD_SERVICE=my-service and Kafka's test_service_override_config both exercise this path and their checked-in snapshots currently omit _dd.svc_src, so snapshot CI will fail unless those expected files are updated or the tag is intentionally ignored.

Useful? React with 👍 / 👎.

@pr-commenter

pr-commenter Bot commented Jun 22, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-22 20:56:32

Comparing candidate commit 07056b7 in PR branch emmett.butler/extra-m with baseline commit 7bc2d63 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 0 unstable metrics.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codeowners resolved as

tests/snapshots/tests.contrib.vertexai.test_vertexai.test_vertexai_completion.json  @DataDog/ml-observability
tests/snapshots/tests.contrib.vertexai.test_vertexai.test_vertexai_completion_error.json  @DataDog/ml-observability
tests/snapshots/tests.contrib.vertexai.test_vertexai.test_vertexai_completion_multiple_messages.json  @DataDog/ml-observability
tests/snapshots/tests.contrib.vertexai.test_vertexai.test_vertexai_completion_stream.json  @DataDog/ml-observability
tests/snapshots/tests.contrib.vertexai.test_vertexai.test_vertexai_completion_stream_error.json  @DataDog/ml-observability
tests/snapshots/tests.contrib.vertexai.test_vertexai.test_vertexai_completion_stream_tool.json  @DataDog/ml-observability
tests/snapshots/tests.contrib.vertexai.test_vertexai.test_vertexai_completion_system_prompt.json  @DataDog/ml-observability
tests/snapshots/tests.contrib.vertexai.test_vertexai.test_vertexai_completion_tool.json  @DataDog/ml-observability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant