[RC-2813] go wrapper#54
Open
mellon85 wants to merge 24 commits into
Open
Conversation
bce1e32 to
894dd5f
Compare
mellon85
commented
Mar 26, 2026
9c7f07d to
b70ad21
Compare
ed7d5cb to
618381f
Compare
ameske
reviewed
Mar 31, 2026
becc00f to
4a31583
Compare
domodwyer
reviewed
Apr 14, 2026
domodwyer
left a comment
Member
There was a problem hiding this comment.
🎉
Quick look over the layout - I'll check the go code after!
f36bf09 to
3b3335c
Compare
7dac780 to
3f76144
Compare
Changes:
* Use build image w/ pre-installed dependencies.
* Use reusable cache action instead to avoid trashing cache.
* Build dev version of FFI harness (faster, more assertions).
* Generate the code prior to running tests (checks codegen).
This is unnecessary - the dependencies are all in the build image already.
These shell expansions aren't evaluated.
3f76144 to
9934775
Compare
We will have more test harness crates for the other crates.
domodwyer
reviewed
Apr 20, 2026
domodwyer
left a comment
Member
There was a problem hiding this comment.
I pushed these changes:
-
ci: install protoc-gen-go in build image (08f1f7c)
-
chore: do not check in generated code (2513d27)
-
ci: simplify and normalise Go workflows (cf6f2af)
Changes: * Use build image w/ pre-installed dependencies. * Use reusable cache action instead to avoid trashing cache. * Build dev version of FFI harness (faster, more assertions). * Generate the code prior to running tests (checks codegen). -
ci: do not install deps that are in build image (c93ae50)
This is unnecessary - the dependencies are all in the build image already. -
chore: do not check in generated test code (afc6071)
-
ci: PATH changes in generator script (4c5cf33)
-
ci(fix): remove ENV for protoc-gen-go (3695f14)
-
ci: gobin path (9934775)
-
refactor(go): rc-x509-test-harness does not reexport (d0303d9)
-
revert: keep existing rx-client name (ac9c75d)
-
refactor: test-harness -> test-harness-ffi (aa2295a)
We will have more test harness crates for the other crates.
The context is propagated across the C API boundaries to the callbacks, so that they are in charge of handling the expiration of the context or the errors carried by it.
24e628e to
0e8050c
Compare
ameske
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
you can check the coverage with
Commits