[parametric] Add version as aggregation key dimension in test_distinct_aggregationkeys_TS003#6869
[parametric] Add version as aggregation key dimension in test_distinct_aggregationkeys_TS003#6869ajgajg1134 wants to merge 6 commits into
Conversation
…gregationkeys_TS003 Extends TS003 to cover per-span version tags as a distinct stats aggregation key. Catches the bug introduced in dd-trace-go v2.8.0 (fixed in PR #4734) where the client-side stats concentrator ignored per-span version meta and collapsed all spans into a version="" bucket. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa00140f19
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
…-rc.2 Per-span version tag support in client-side stats aggregation key was fixed in dd-trace-go#4734 and released in v2.8.2-rc.2. Gate the new version dimension assertion so CI does not fail on older tracer builds. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Summary
test_distinct_aggregationkeys_TS003to coverversionas the 7th distinct stats aggregation key dimensionversionmeta tag (version=v1.0.0) alongside the existing 6 dimensions (service, name, resource, type, http_status_code, synthetics)Motivation
This test was written to catch a bug in dd-trace-go v2.8.0 (DataDog/dd-trace-go#4734) where the client-side stats concentrator ignored per-span
versionmeta tags and collapsed all spans into aversion=""bucket. The bug was introduced when/infopolling was added to dynamically activate client-side stats — the concentrator's aggregation key was initialized once at construction time from global config, never reading per-span version tags.Verified:
Hits=2instead of two buckets withHits=1)5655505) from fix(ddtrace/tracer): wire version on aggregation key when adding a span to client-side stats dd-trace-go#4734Test plan
TEST_LIBRARY=golang ./run.sh PARAMETRIC -k test_distinct_aggregationkeys_TS003against default tracer → FAIL (confirms bug detection)binaries/golang-load-from-go-getpointing to fix commit5655505e021b40ea2839bc8dda482ec19483047a→ PASS (confirms fix validation)🤖 Generated with Claude Code