feat(draw): migrate plugin - #895
Open
warm-coolguy wants to merge 43 commits into
Open
Conversation
warm-coolguy
requested review from
czirkelbach,
dopenguin,
oeninghe-dataport and
raschju
as code owners
July 24, 2026 07:37
warm-coolguy
force-pushed
the
feature/draw-migration
branch
from
July 24, 2026 07:42
ea6e36a to
6b32c32
Compare
|
dopenguin
force-pushed
the
feature/draw-migration
branch
from
July 29, 2026 14:14
387027a to
379ec1b
Compare
dopenguin
force-pushed
the
feature/draw-migration
branch
from
July 29, 2026 15:32
99c7cef to
75de0f5
Compare
…ionManager At least one layer always exists so no lookup in the interactionManager is necessary.
dopenguin
force-pushed
the
feature/draw-migration
branch
from
August 13, 2026 20:22
7d7c422 to
9d2a6bb
Compare
dopenguin
reviewed
Aug 14, 2026
| <!-- eslint-disable vue/enforce-style-attribute --> | ||
| <template> | ||
| <div class="polar-icon-button-select"> | ||
| <PolarIconButton |
Member
There was a problem hiding this comment.
Why not use KernButton here? Especially as the kern-label basically is duplicated now
Typically used anyway and normally required.
dopenguin
reviewed
Aug 14, 2026
Comment on lines
+13
to
+23
| <div class="kern-form-input"> | ||
| <label class="kern-label" for="polar-plugin-draw-textarea"> | ||
| {{ $t(($) => $.text.content, { ns: PluginId }) }} | ||
| </label> | ||
| <textarea | ||
| id="polar-plugin-draw-textarea" | ||
| v-model="textInput" | ||
| class="kern-form-input__input" | ||
| name="polar-plugin-draw-textarea" | ||
| /> | ||
| </div> |
Member
There was a problem hiding this comment.
Do you think we'll have more textareas? If so, this might be a great reusable component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draw is migrated.
Instructions for local reproduction and review
I don't know!
Making this PR so that we have a running example on the web for bug hunt.
Pull Request Checklist (for Assignee)
UI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)
Relevant tickets, issues, et cetera