Skip to content

Fix indexing and query parsing issues#1424

Merged
fblanqui merged 12 commits into
Deducteam:masterfrom
Alidra:indexing_2026
Jun 26, 2026
Merged

Fix indexing and query parsing issues#1424
fblanqui merged 12 commits into
Deducteam:masterfrom
Alidra:indexing_2026

Conversation

@Alidra

@Alidra Alidra commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary:

  • Fix parsing to preserve trailing characters after query
  • Restore notation support by correcting required file requiring in cli/lambdapi.ml
  • Add position info to query command error messages
  • Prevent websearch server from crashing in case of syntax errors
  • Restore the feature of streaming the search results in command line
  • Use uniform types for query formatting functions and remove dual syntax-tree/string acceptance

Details:

  • This branch implements several minor fixes after Improvements and new features for indexing #1290 , focused on search indexing and query handling. It ensures query parsing is handled in the right phase, improves CLI error reporting, and prevents incorrect search results when syntax errors occur.

@Alidra

Alidra commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

@sacerdot @fblanqui I believe this PR is ready for merge.
There is still a problem with the parser because the list function does not behave expected in case of erroneous trailing tokens after the one expected with prefix but this problem is beyond the current changes and I propose to fix it in a dedicated PR

@fblanqui fblanqui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. But there are many changes that are not true changes, just reindentation. Could you please minimize the diff. Ill review it once it will be minimized.

Comment thread TODO.md Outdated
Comment thread src/handle/query.ml Outdated
Comment thread src/handle/query.ml Outdated
Comment thread src/handle/query.ml
Comment thread src/parsing/rocqParser.ml Outdated
Comment thread src/parsing/rocqParser.ml Outdated
Comment thread src/parsing/rocqParser.ml Outdated
Comment thread src/tool/indexing.ml Outdated
@fblanqui fblanqui merged commit 3598ca5 into Deducteam:master Jun 26, 2026
24 checks passed
@fblanqui

Copy link
Copy Markdown
Member

Thank you @Alidra !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants