Skip to content

Add fixes for ASIC controls with DeepWater Desktop v1.2.0 #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandonhs merged 2 commits into from
Sep 2, 2026
Merged

Add fixes for ASIC controls with DeepWater Desktop v1.2.0 #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09a7a24
Remove reapply_sensor_config() from on_external_stream_started() to f…
brandonhs Sep 2, 2026
11925b3
feat(cameras)!: disable camera controls on external management
brandonhs Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend_py/src/services/cameras/drivers/shd/shd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def can_follow(self) -> bool:
def on_external_stream_started(self) -> None:
# Override method
# We reapply assuming the stream has already been started
self.reapply_sensor_config()
# self.reapply_sensor_config()

# We then want to apply the config from the camera
mjpeg_camera = self.find_camera_with_format("MJPG")
Expand Down
4 changes: 3 additions & 1 deletion frontend/src/components/dwe/cameras/camera-controls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ export const CameraControls = ({
<InternalControlWrapper
key={uiControls[name].control_id}
control={uiControls[name]}
disabled={device.is_managed}
// NOTE: External management behavior is changed after v0.7.3 to account for SDK v1.2.0 changes
// This means versions AFTER v0.7.3 will no longer work as intended with SDK versions before v1.2.0
disabled={device.is_managed || device.is_externally_managed}
/>
),
)}
Expand Down
Loading