Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the monorepo’s Node.js baseline to v24 by enforcing Node requirements in workspace manifests and aligning CI to use a single version source (.node-version).
Changes:
- Add
engines.node >=24across packages/apps to declare the new minimum Node version. - Add
.node-version(24.15.0) / update.tool-versions, and switch GitHub Actions workflows tonode-version-file. - Enable
engine-strict=truein.npmrc(root andpackages/sbom) to enforce engine checks during installs.
Reviewed changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/testcafe-models/package.json | Add Node >=24 engine requirement. |
| packages/sbom/package.json | Add Node >=24 engine requirement. |
| packages/sbom/.npmrc | Enforce engine checks for sbom workspace. |
| packages/nx-infra-plugin/package.json | Add Node >=24 engine requirement. |
| packages/eslint-migration-utils/package.json | Add Node >=24 engine requirement. |
| packages/devextreme/package.json | Add Node >=24 engine requirement. |
| packages/devextreme-vue/package.json | Add Node >=24 engine requirement. |
| packages/devextreme-themebuilder/package.json | Add Node >=24 engine requirement. |
| packages/devextreme-scss/package.json | Add Node >=24 engine requirement. |
| packages/devextreme-react/package.json | Add Node >=24 engine requirement. |
| packages/devextreme-monorepo-tools/package.json | Add Node >=24 engine requirement. |
| packages/devextreme-metadata/package.json | Add Node >=24 engine requirement. |
| packages/devextreme-dist/package.json | Add Node >=24 engine requirement. |
| packages/devextreme-angular/package.json | Add Node >=24 engine requirement. |
| package.json | Add Node >=24 engine requirement for the workspace root. |
| e2e/wrappers/package.json | Add Node >=24 engine requirement. |
| e2e/testcafe-devextreme/package.json | Add Node >=24 engine requirement. |
| e2e/devextreme-bundler/package.json | Add Node >=24 engine requirement. |
| e2e/compilation-cases/package.json | Add Node >=24 engine requirement. |
| e2e/bundlers/package.json | Add Node >=24 engine requirement. |
| apps/vue/package.json | Add Node >=24 engine requirement. |
| apps/react/package.json | Add Node >=24 engine requirement. |
| apps/react-storybook/package.json | Add Node >=24 engine requirement. |
| apps/demos/package.json | Add Node >=24 engine requirement. |
| apps/angular/package.json | Add Node >=24 engine requirement. |
| .tool-versions | Bump asdf Node version to 24.15.0. |
| .npmrc | Enforce engine checks at repo root. |
| .node-version | Add canonical Node version file (24.15.0) for CI/local tools. |
| .github/workflows/wrapper_tests_e2e.yml | Switch CI Node selection to .node-version. |
| .github/workflows/wrapper_tests.yml | Switch CI Node selection to .node-version. |
| .github/workflows/visual-tests-demos.yml | Switch CI Node selection to .node-version. |
| .github/workflows/update_version.yml | Switch CI Node selection to .node-version. |
| .github/workflows/ts_declarations.yml | Switch CI Node selection to .node-version. |
| .github/workflows/themebuilder_tests.yml | Switch CI Node selection to .node-version. |
| .github/workflows/testcafe_tests.yml | Switch CI Node selection to .node-version. |
| .github/workflows/styles.yml | Switch CI Node selection to .node-version. |
| .github/workflows/run-testcafe-on-gh-pages.yml | Switch CI Node selection to .node-version. |
| .github/workflows/renovation.yml | Switch CI Node selection to .node-version. |
| .github/workflows/qunit_tests.yml | Switch CI Node selection to .node-version. |
| .github/workflows/publish-demos.yml | Switch CI Node selection to .node-version. |
| .github/workflows/pr-storybook-deploy-manual.yml | Switch CI Node selection to .node-version. |
| .github/workflows/playgrounds_tests.yml | Switch CI Node selection to .node-version. |
| .github/workflows/packages_publishing.yml | Switch CI Node selection to .node-version. |
| .github/workflows/lint.yml | Switch CI Node selection to .node-version. |
| .github/workflows/demos_unit_tests.yml | Switch CI Node selection to .node-version. |
| .github/workflows/default_workflow.yml | Switch CI Node selection to .node-version. |
| .github/workflows/codeql.yml | Switch CI Node selection to .node-version. |
| .github/workflows/build_all.yml | Switch CI Node selection to .node-version (partial; see comments). |
pharret31
reviewed
Apr 23, 2026
| @@ -0,0 +1 @@ | |||
| 24.15.0 No newline at end of file | |||
Contributor
There was a problem hiding this comment.
don't forget to add eols
dmlvr
force-pushed
the
26_1_fix_node_version
branch
from
2e46a5b to
fdf1d12
Compare
pharret31
reviewed
Apr 23, 2026
| "version": "26.1.0", | ||
| "license": "MIT", | ||
| "author": "Developer Express Inc.", | ||
| "engines": { "node": ">=24" }, |
Contributor
There was a problem hiding this comment.
???
I would suggest use the syntax that renovate bot suggests in the documentation: node: ^24.15.0
https://docs.renovatebot.com/node/#configuring-which-version-of-npm-renovate-uses
UPD: node: 24.15.0, since the updation would be automatic by renovate and it won't update version with caret
Contributor
Author
There was a problem hiding this comment.
We need to fix major version here, renovate bot should update .node-version file, based on our last discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.