Skip to content

Configure chmod#789

Merged
tieneupin merged 20 commits intomainfrom
configure-chmod
Apr 29, 2026
Merged

Configure chmod#789
tieneupin merged 20 commits intomainfrom
configure-chmod

Conversation

@tieneupin
Copy link
Copy Markdown
Contributor

@tieneupin tieneupin commented Apr 23, 2026

Adds keys to the MachineConfig that can be used to control the permissions level of the rsync command on the client and the mkdir command on the backend. Updates the client and server so that the corresponding permissions are passed in from the MachineConfig.

Actual diff is about +60/-20. The rest of it is due to the addition of new tests to improve coverage.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 69.23077% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.43%. Comparing base (00a3938) to head (247521b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   50.72%   51.43%   +0.70%     
==========================================
  Files          96       96              
  Lines       10059    10101      +42     
  Branches     1322     1322              
==========================================
+ Hits         5102     5195      +93     
+ Misses       4690     4634      -56     
- Partials      267      272       +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…r a directory is created; updated 'make_rsyncer_destination' so that it also creates the directory of the folder being rsync'ed, not just the parent folder
Comment thread src/murfey/server/gain.py Dismissed
@tieneupin tieneupin self-assigned this Apr 28, 2026
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component client Relates to the client component labels Apr 28, 2026
@tieneupin tieneupin marked this pull request as ready for review April 28, 2026 18:14
@tieneupin tieneupin merged commit 84e0b4a into main Apr 29, 2026
17 checks passed
@tieneupin tieneupin deleted the configure-chmod branch April 29, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client component enhancement New feature or request server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants