fix: add AEC_MODI and AEC_SYMB_SECTION as ProxyEntity in readUnlisted… - #1148
Open
WallanceLee wants to merge 1 commit into
Open
fix: add AEC_MODI and AEC_SYMB_SECTION as ProxyEntity in readUnlisted…#1148WallanceLee wants to merge 1 commit into
WallanceLee wants to merge 1 commit into
Conversation
…Type AEC custom objects (TDbSymbModi, TDbSymbSection) from BIM applications like Revit/Tianzheng are stored in DWG with proxy graphics for fallback display in AutoCAD. ACadSharp previously read these as UnknownEntity, causing their proxy graphics to be lost. Route them through readProxyEntity() so the proxy geometry data is preserved in ProxyGeometries for downstream exporters.
Author
|
@DomCR Could you review this PR and let me know if you need some modification? |
Owner
|
Hi @WallanceLee, Could you provide a file that contains those entities? Your solution may work for these entities but given that they are part of AEC, maybe there is a more generic and better solution to include the different objects that haven't been implemented like the Thanks! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AEC custom objects (TDbSymbModi, TDbSymbSection) from BIM applications like Revit/Tianzheng are stored in DWG with proxy graphics for fallback display in AutoCAD. ACadSharp previously read these as UnknownEntity, causing their proxy graphics to be lost. Route them through readProxyEntity() so the proxy geometry data is preserved in ProxyGeometries for downstream exporters.
Description
I don't have a further knownledge about the case branches, and following is from my test data and notification handler.
Tasks done in this PR
Related Issues / Pull Requests
Notes for reviewer