Widen dependency versions#64
Open
pkruithof wants to merge 1 commit into
Open
Conversation
pkruithof
commented
Jul 23, 2026
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| deps: |
Author
There was a problem hiding this comment.
Ideally you'd want to add different PHP versions to this as well. I'll leave that out of scope for this PR though.
Author
There was a problem hiding this comment.
Not sure why there were no workflows triggered for this PR though, the file syntax seems ok and I don't see any errors in the actions tab.
pkruithof
commented
Jul 23, 2026
| use Psr\Http\Client\ClientExceptionInterface; | ||
| use Psr\Http\Client\ClientInterface; | ||
| use Psr\Http\Message\RequestFactoryInterface; | ||
| use Teapot\StatusCode\RFC\RFC7231; |
Author
There was a problem hiding this comment.
Having a dependency just for readable http status codes, and enforcing that on all who install this library seems a bit wasteful. But if you insist on keeping this I can revert this, although in that case I would suggest using symfony/http-foundation as it's a far more common dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
We're using Eppo with this library and want to upgrade to Symfony 8. Currently the cache dependency is preventing that.
Description
I've widened the requirement for this dependency, and fixed some low-hanging fruit I encountered while doing so:
composer.lockas it's not recommended for librariesHow has this been documented?
How has this been tested?
make test