Fix Home - Task is not created in Concierge after sending [] task from Concierge prompt box by GCyganek · Pull Request #99543 · Expensify/App

GCyganek · 2026-08-26T09:33:53Z

Explanation of Change

Sending [] task from the Concierge prompt box posted a plain message instead of creating a task. Extracted the [] title + optional @mention markdown handling out of useComposerSubmit into a reusable createTaskFromMarkdown action in Task.ts, and called it from useAskConcierge before falling back to addComment.

Also adding CONST.TITLE_CHARACTER_LIMIT check to make sure validation matches Concierge composer validation

Fixed Issues

$ #99497
PROPOSAL: N/A

Tests

Go to staging.new.expensify.com
Go to Home.
Enter [] task on Concierge prompt box and send the message.
Verify task is created

Max length validation:

Go to staging.new.expensify.com
Go to Home.
Enter [] task on Concierge prompt box with title longer than 100 characters.
Verify that submit and add attachment buttons are disabled and that the maximum task length error is displayed below the prompt box
Shorten the title to less than 100 characters
Verify that submit and add attachment buttons switch to enabled state and that the error disappears

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-08-26.at.11.49.47.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-08-26.at.11.48.34.mov

Screen.Recording.2026-08-26.at.13.02.31.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-08-26.at.11.45.07.mov

Screen.Recording.2026-08-26.at.12.55.37.mov

…m Concierge prompt box

GCyganek · 2026-08-26T09:44:50Z

@codex please review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: afdb57eb33

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-26T09:48:54Z

        }
        openConciergeAnywhere({forceConcierge});
+
+        if (createTaskFromMarkdown({text: trimmedQuery, parentReport: targetReport, currentUserPersonalDetails, quickAction})) {


Enforce the shorthand task-title limit before creating tasks

When the Home prompt contains a [] title longer than CONST.TITLE_CHARACTER_LIMIT, this new path calls createTaskFromMarkdown() and clears the input without any length validation. The report composer explicitly rejects the same shorthand in useDebouncedCommentMaxLengthValidation, but ConciergePromptBox only checks that the value is nonempty, so Home can now submit task titles that the established composer flow prevents; enforce the same limit before claiming and creating the task.

Useful? React with 👍 / 👎.

From what I see it's true, but I'd handle it as a follow-up

nvm, I'll add a fix here

codecov · 2026-08-26T09:50:16Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...components/Search/SearchRouter/useAskConcierge.tsx	`95.65% <100.00%> (+0.91%)`	⬆️
...ox/report/ReportActionCompose/useComposerSubmit.ts	`62.00% <100.00%> (-4.67%)`	⬇️
src/styles/index.ts	`63.36% <ø> (ø)`
...rc/pages/home/ForYouSection/ConciergePromptBox.tsx	`98.90% <97.61%> (+0.10%)`	⬆️
src/libs/actions/Task.ts	`67.10% <89.65%> (+2.74%)`	⬆️
... and 9 files with indirect coverage changes

melvin-bot · 2026-08-26T09:56:19Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-08-26T10:56:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-08-26.13.18.30.mov

Android: mWeb Chrome

2026-08-26.13.16.15.mov

iOS: HybridApp

2026-08-26.13.18.30.mov

iOS: mWeb Safari

2026-08-26.13.16.15.mov

MacOS: Chrome / Safari

2026-08-26.13.05.36.mov

ZhenjaHorbach · 2026-08-26T11:10:29Z

Minor comment
But should we add additional padding when we have an error?
Or should we have the same padding between the input and the time-sensitive header?
CC: @Expensify/design

ZhenjaHorbach · 2026-08-26T11:26:59Z

But overall changes look good

shawnborton · 2026-08-26T12:57:20Z

Or should we have the same padding between the input and the time-sensitive header?

Can we see what that looks like? It could be nice if the UI doesn't jump, so I kinda like this idea of keeping a fixed area of bottom padding and the error message just shows up within that space.

ZhenjaHorbach · 2026-08-26T13:00:47Z

Or should we have the same padding between the input and the time-sensitive header?

Can we see what that looks like? It could be nice if the UI doesn't jump, so I kinda like this idea of keeping a fixed area of bottom padding and the error message just shows up within that space.

shawnborton · 2026-08-26T13:04:26Z

Oh sorry, I meant what if we used a fixed space below the composer, and the error message simply sat within that fixed space and didn't cause the fixed space to grow... let me know if that makes sense.

ZhenjaHorbach · 2026-08-26T13:05:29Z

Or should we have the same padding between the input and the time-sensitive header?

Can we see what that looks like? It could be nice if the UI doesn't jump, so I kinda like this idea of keeping a fixed area of bottom padding and the error message just shows up within that space.

Yeah
I think we have enough space to show the error without additional space

shawnborton · 2026-08-26T13:06:46Z

Hmmm I don't think we're on the same page here. The gap between the bottom of the composer box and the label of "Time sensitive" or "For you" should always remain fixed. Does that make sense?

ZhenjaHorbach · 2026-08-26T13:11:46Z

Hmmm I don't think we're on the same page here. The gap between the bottom of the composer box and the label of "Time sensitive" or "For you" should always remain fixed. Does that make sense?

That's what I'm talking about 😁
Because at the moment, the error adds additional padding

shawnborton · 2026-08-26T13:22:17Z

Haha okay, let's do it then?

garrettmknight

Feels like this'll be really rare in practice, but looks good from a product perspective.

ZhenjaHorbach · 2026-08-26T13:28:07Z

Haha okay, let's do it then?

But are we okay with this?
Or should we have a fixed padding between the input and the Time sensitive header (with and without the error text)?

shawnborton · 2026-08-26T13:29:44Z

I am saying we should have a fixed box of space between the input and the label below. If the error message appears, it does not add any more space - it should appear within the existing fixed box of space. Happy to jump on a call or make a prototype if that helps.

ZhenjaHorbach · 2026-08-26T13:31:58Z

I am saying we should have a fixed box of space between the input and the label below. If the error message appears, it does not add any more space - it should appear within the existing fixed box of space. Happy to jump on a call or make a prototype if that helps.

It's okay!
The main thing is that we reached a consensus 😁
@GCyganek
Could you please update the padding, please?

GCyganek · 2026-08-26T13:54:46Z

@ZhenjaHorbach on it!

…reated

GCyganek · 2026-08-26T14:21:45Z

Fixed:

Screen.Recording.2026-08-26.at.16.16.44.mov

Screen.Recording.2026-08-26.at.16.20.32.mov

@shawnborton you can see how it looks without the Time sensitive session as well above on Android simulator

ZhenjaHorbach · 2026-08-26T14:23:21Z

As for me looks good!

shawnborton · 2026-08-26T14:33:08Z

That looks good when there is a section under it. On mobile on your left mock, I think we could use 12px of extra padding below the input so that the red text isn't quite as close to the bottom edge.

Fix Home - Task is not created in Concierge after sending [] task fro…

d89e196

…m Concierge prompt box

melvin-bot Bot assigned GCyganek Aug 26, 2026

GCyganek changed the title ~~Fix Home - Task is not created in Concierge after sending [] task fro…~~ Fix Home - Task is not created in Concierge after sending [] task from Concierge prompt box Aug 26, 2026

GCyganek added 2 commits August 26, 2026 11:42

Fix and add tests

da925b8

Comments

afdb57e

Fix knip check

7830e10

chatgpt-codex-connector Bot reviewed Aug 26, 2026

View reviewed changes

GCyganek marked this pull request as ready for review August 26, 2026 09:56

GCyganek requested review from a team as code owners August 26, 2026 09:56

melvin-bot Bot requested review from ZhenjaHorbach and garrettmknight and removed request for a team August 26, 2026 09:56

melvin-bot Bot removed the request for review from a team August 26, 2026 09:56

Fix comment max length check

080f9c8

ZhenjaHorbach approved these changes Aug 26, 2026

View reviewed changes

melvin-bot Bot requested review from grgia and puneetlath August 26, 2026 11:26

garrettmknight previously approved these changes Aug 26, 2026

View reviewed changes

Merge branch 'main' into @GCyganek/concierge-prompt-box/task-is-not-c…

f4c8a91

…reated

GCyganek dismissed garrettmknight’s stale review via f4c8a91 August 26, 2026 14:05

Fix ExceededCommentLength adding more space below composer

32461e3

GCyganek requested a review from a team as a code owner August 26, 2026 14:16

ZhenjaHorbach approved these changes Aug 26, 2026

View reviewed changes

ZhenjaHorbach mentioned this pull request Aug 26, 2026

Fix "Home - No "The maximum comment length is 15,000 characters" error on Concierge prompt box" #99548

Open

52 tasks

Uh oh!

Conversation

GCyganek commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

GCyganek commented Aug 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

GCyganek Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

GCyganek Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Aug 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Aug 26, 2026

Uh oh!

ZhenjaHorbach commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Aug 26, 2026

Uh oh!

ZhenjaHorbach commented Aug 26, 2026

Uh oh!

shawnborton commented Aug 26, 2026

Uh oh!

ZhenjaHorbach commented Aug 26, 2026

Uh oh!

shawnborton commented Aug 26, 2026

Uh oh!

ZhenjaHorbach commented Aug 26, 2026

Uh oh!

shawnborton commented Aug 26, 2026

Uh oh!

ZhenjaHorbach commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Aug 26, 2026

Uh oh!

garrettmknight left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Aug 26, 2026

Uh oh!

shawnborton commented Aug 26, 2026

Uh oh!

ZhenjaHorbach commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GCyganek commented Aug 26, 2026

Uh oh!

GCyganek commented Aug 26, 2026

Uh oh!

ZhenjaHorbach commented Aug 26, 2026

Uh oh!

shawnborton commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

GCyganek commented Aug 26, 2026 •

edited

Loading

codecov Bot commented Aug 26, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Aug 26, 2026 •

edited

Loading

ZhenjaHorbach commented Aug 26, 2026 •

edited

Loading

ZhenjaHorbach commented Aug 26, 2026 •

edited

Loading