Skip to content

Fix Home - Task is not created in Concierge after sending [] task from Concierge prompt box - #99543

Merged
grgia merged 10 commits into
Expensify:mainfrom
software-mansion-labs:@GCyganek/concierge-prompt-box/task-is-not-created
Aug 27, 2026
Merged

Fix Home - Task is not created in Concierge after sending [] task from Concierge prompt box#99543
grgia merged 10 commits into
Expensify:mainfrom
software-mansion-labs:@GCyganek/concierge-prompt-box/task-is-not-created

Conversation

@GCyganek

@GCyganek GCyganek commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Sending [] task from the Concierge prompt box posted a plain message instead of creating a task. Extracted the [] title + optional @mention markdown handling out of useComposerSubmit into a reusable createTaskFromMarkdown action in Task.ts, and called it from useAskConcierge before falling back to addComment.

Also adding CONST.TITLE_CHARACTER_LIMIT check to make sure validation matches Concierge composer validation

Fixed Issues

$ #99497
PROPOSAL: N/A

Tests

  1. Go to staging.new.expensify.com
  2. Go to Home.
  3. Enter [] task on Concierge prompt box and send the message.
  4. Verify task is created

Max title length validation:

  1. Go to staging.new.expensify.com
  2. Go to Home.
  3. Enter [] task on Concierge prompt box with title longer than 100 characters.
  4. Verify that submit and add attachment buttons are disabled and that the maximum task length error is displayed below the prompt box
  5. Shorten the title to less than 100 characters
  6. Verify that submit and add attachment buttons switch to enabled state and that the error disappears

Max message length validation:

  1. Open "Home" page
  2. Enter some short text into Concierge input - check if it stays green and possible to submit.
  3. Enter long message (15000+ characters) - check if it turns red with an error message "The maximum content legth is 15,000 characters." and is disabled.
  4. Shorten the test to a <15000 character length - check if it turns back green and is possible to submit.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-26.at.11.49.47.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-08-26.at.11.48.34.mov
Screen.Recording.2026-08-26.at.13.02.31.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-26.at.11.45.07.mov
Screen.Recording.2026-08-26.at.12.55.37.mov

@GCyganek GCyganek changed the title Fix Home - Task is not created in Concierge after sending [] task fro… Fix Home - Task is not created in Concierge after sending [] task from Concierge prompt box Aug 26, 2026
@GCyganek

Copy link
Copy Markdown
Contributor Author

@codex please review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: afdb57eb33

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

}
openConciergeAnywhere({forceConcierge});

if (createTaskFromMarkdown({text: trimmedQuery, parentReport: targetReport, currentUserPersonalDetails, quickAction})) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Enforce the shorthand task-title limit before creating tasks

When the Home prompt contains a [] title longer than CONST.TITLE_CHARACTER_LIMIT, this new path calls createTaskFromMarkdown() and clears the input without any length validation. The report composer explicitly rejects the same shorthand in useDebouncedCommentMaxLengthValidation, but ConciergePromptBox only checks that the value is nonempty, so Home can now submit task titles that the established composer flow prevents; enforce the same limit before claiming and creating the task.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see it's true, but I'd handle it as a follow-up

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I'll add a fix here

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...components/Search/SearchRouter/useAskConcierge.tsx 95.65% <100.00%> (+0.91%) ⬆️
src/pages/home/ForYouSection/index.tsx 100.00% <100.00%> (ø)
...ox/report/ReportActionCompose/useComposerSubmit.ts 62.00% <100.00%> (-4.67%) ⬇️
src/styles/index.ts 63.36% <ø> (ø)
...rc/pages/home/ForYouSection/ConciergePromptBox.tsx 98.95% <97.82%> (+0.09%) ⬆️
src/libs/actions/Task.ts 67.10% <89.65%> (+2.74%) ⬆️
... and 7 files with indirect coverage changes

@GCyganek
GCyganek marked this pull request as ready for review August 26, 2026 09:56
@GCyganek
GCyganek requested review from a team as code owners August 26, 2026 09:56
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and garrettmknight and removed request for a team August 26, 2026 09:56
@melvin-bot

melvin-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 26, 2026 09:56
@ZhenjaHorbach

ZhenjaHorbach commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-08-26.13.18.30.mov
Android: mWeb Chrome
2026-08-26.13.16.15.mov
iOS: HybridApp
2026-08-26.13.18.30.mov
iOS: mWeb Safari
2026-08-26.13.16.15.mov
MacOS: Chrome / Safari
2026-08-26.13.05.36.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Minor comment
But should we add additional padding when we have an error?
Or should we have the same padding between the input and the time-sensitive header?
CC: @Expensify/design

Снимок экрана — 2026-08-26 в 13 07 43 Снимок экрана — 2026-08-26 в 13 07 49

@melvin-bot
melvin-bot Bot requested review from grgia and puneetlath August 26, 2026 11:26
@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

But overall changes look good

@shawnborton

Copy link
Copy Markdown
Contributor

Or should we have the same padding between the input and the time-sensitive header?

Can we see what that looks like? It could be nice if the UI doesn't jump, so I kinda like this idea of keeping a fixed area of bottom padding and the error message just shows up within that space.

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Or should we have the same padding between the input and the time-sensitive header?

Can we see what that looks like? It could be nice if the UI doesn't jump, so I kinda like this idea of keeping a fixed area of bottom padding and the error message just shows up within that space.

Снимок экрана — 2026-08-26 в 15 00 25 Снимок экрана — 2026-08-26 в 15 00 31

@shawnborton

Copy link
Copy Markdown
Contributor

Oh sorry, I meant what if we used a fixed space below the composer, and the error message simply sat within that fixed space and didn't cause the fixed space to grow... let me know if that makes sense.

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Or should we have the same padding between the input and the time-sensitive header?

Can we see what that looks like? It could be nice if the UI doesn't jump, so I kinda like this idea of keeping a fixed area of bottom padding and the error message just shows up within that space.

Yeah
I think we have enough space to show the error without additional space

Снимок экрана — 2026-08-26 в 15 00 25 Снимок экрана — 2026-08-26 в 15 00 31

@shawnborton

Copy link
Copy Markdown
Contributor

Hmmm I don't think we're on the same page here. The gap between the bottom of the composer box and the label of "Time sensitive" or "For you" should always remain fixed. Does that make sense?

@ZhenjaHorbach

ZhenjaHorbach commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Hmmm I don't think we're on the same page here. The gap between the bottom of the composer box and the label of "Time sensitive" or "For you" should always remain fixed. Does that make sense?

That's what I'm talking about 😁
Because at the moment, the error adds additional padding

@ZhenjaHorbach

ZhenjaHorbach commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

I am saying we should have a fixed box of space between the input and the label below. If the error message appears, it does not add any more space - it should appear within the existing fixed box of space. Happy to jump on a call or make a prototype if that helps.

It's okay!
The main thing is that we reached a consensus 😁
@GCyganek
Could you please update the padding, please?

@GCyganek

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach on it!

@GCyganek
GCyganek requested a review from a team as a code owner August 26, 2026 14:16
@GCyganek

Copy link
Copy Markdown
Contributor Author

Fixed:

Screen.Recording.2026-08-26.at.16.16.44.mov
Screen.Recording.2026-08-26.at.16.20.32.mov

@shawnborton you can see how it looks without the Time sensitive session as well above on Android simulator

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

As for me looks good!

@shawnborton

Copy link
Copy Markdown
Contributor

That looks good when there is a section under it. On mobile on your left mock, I think we could use 12px of extra padding below the input so that the red text isn't quite as close to the bottom edge.

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

@GCyganek
Can you please fix the last comment?
And we have conflicts 😅

@GCyganek

Copy link
Copy Markdown
Contributor Author

@GCyganek Can you please fix the last comment? And we have conflicts 😅

On it!

@GCyganek

Copy link
Copy Markdown
Contributor Author

Added 12 px of extra bottom padding when only Concierge prompt box is rendered in the section:

Screenshot 2026-08-27 at 10 20 00 Screenshot 2026-08-27 at 10 20 25

@shawnborton

Copy link
Copy Markdown
Contributor

Looks great, let's ship it

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

@grgia @puneetlath
Let's merge this!

@grgia
grgia merged commit f9672cf into Expensify:main Aug 27, 2026
34 of 35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.63-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no changes required

I reviewed this PR against the help articles under App/docs/articles and no help site changes are required. No draft PR was created.

Why: This is a bug fix, not a new user-facing feature. It wires the existing [] Title markdown shortcut (previously only handled in the regular composer via useComposerSubmit) into the Concierge prompt box on Home by extracting it into a reusable createTaskFromMarkdown action. The [] Title markdown syntax itself is unchanged and was never a documented flow.

The two articles that touch this area both remain accurate as written:

  • Assign a Task via Chat — documents task creation via the + button → Assign a Task, which this PR does not touch.
  • Concierge in Expensify — describes what Concierge can do; the prompt box behavior it references is unaffected.

The [] Title markdown shortcut is an undocumented power-user syntax in both the current and the fixed state, so this fix doesn't make any existing help content inaccurate. If the team decides the shortcut should be documented as an alternative task-creation method, that would be a separate content decision rather than something required by this PR — happy to draft it if you'd like.

@GCyganek — since no docs changes are required, there's no linked help site PR to review. Let me know if you'd prefer I still add documentation for the [] Title task shortcut.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants