Create complete-a-hotel-stay-using-travel-invoicing

[bfitzexpensify]

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[OSBotify]

A preview of your ExpensifyHelp changes have been deployed to https://5e78bd7e.helpdot.pages.dev ⚡️

[bfitzexpensify]

@stephanieelliott I'm not seeing a preview from #89604 (comment) - is that because I'm trying to make a new hub/folder?

[melvin-bot]

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5205d67ce3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Place the article under docs/articles so it is routed

This new help article is added as an extensionless file under docs/travel/hubs, but the ExpensifyHelp route generation only scans docs/articles/<platform>/<hub> entries ending in .md (checked .github/scripts/createDocsRoutes.ts, which reads docs/articles/... and only pushes files with .md). Because of that, this page will not be included in the generated hub/LHN article data or article preview links, so users won't be able to discover it from the travel help site. Please move it to the appropriate docs/articles/travel/.../*.md path and add any needed route/hub metadata.

Useful? React with 👍 / 👎.

[bfitzexpensify]

Comverting this back to a draft while I make the new hub

[bfitzexpensify]

Held on #89730

[stephanieelliott]

@bfitzexpensify it's because you created the article under docs/travel/hubs/travel-invoicing -- you'd want add the article under docs/articles/travel/travel-invoicing.

But the unmerged update to _routes.yml in #89730 may cause an issue with the build too. I pushed a commit to add docs/articles/travel/travel-invoicing to this branch, but I think this might be easiest if you consolidate everything to your other PR that way you can definitely preview it.

You'll want to make sure you have:

• docs/travel/hubs/travel-invoicing, and add an index file like this one.
• docs/articles/travel/travel-invoicing and put your article in that folder. And also make sure it has the .md extension.

[bfitzexpensify]

Sorry @stephanieelliott I've made a dogs breakfast of this. Let me just sense-check myself for next steps:

1. Add the hub - happening via [No QA] Update _routes.yml #89730
2. Add the index file - seems I'll need to wait for the hub to be live to do that?
3. Add all of the articles to docs/articles/travel/travel-invoicing (and update them to .md) - done for Create complete-a-hotel-stay-using-travel-invoicing #89604, Create How to Enable and Manage-Travel-Invoicing.md #77233, and Create How-to-Use-Travel-Invoicing #77234

Anything I'm missing from that?

[stephanieelliott]

Almost @bfitzexpensify! Updating _routes.yml does not add the hub (it's more like a pre-requisite to adding a hub), and because you haven't added a hub that corresponds with the update to that file, it causing a build error in #89730. So you're stuck until you add the hub, and you can't add a new hub without an article to put in it. So that's why I recommended doing it all in one PR, it's way less complicated that way!

Here is what you want to do:

1. Go to your branch https://github.com/Expensify/App/tree/bfitzexpensify-patch-13 (where you updated _routes.yml)
2. In that branch, add the hub:
   • At docs/travel/hubs add a folder called travel-policy
   • within the folder, create the index.html
3. While still in that branch, add the articles folder:
   • At docs/articles/travel add a folder called travel-policy
   • within the folder, add at least one article

Once you do that, go back to #89730 and you should see the build error resolve, and preview link should show the new hub + article