Fix: Update billable setting page - #98258
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61a1c26ed7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Explanation of Change
Fix: Update billable setting page
Fixed Issues
$ #97930
PROPOSAL: #97930 (comment)
Tests
Precondition:
rulesRevampbeta is enabledBillable expensedisplays an empty descriptionBillable expenseChoose whether cash and credit card expenses should be billable by default.Billable/Non-Billableand saveBillable expensedescription displays the correct description based onBillable/Non-BillablevalueOffline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-11.at.14.09.37.mov
Android: mWeb Chrome
Screen.Recording.2026-08-11.at.14.04.24.mov
iOS: Native
Screen.Recording.2026-08-11.at.14.06.42.mov
iOS: mWeb Safari
Screen.Recording.2026-08-11.at.14.07.31.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-11.at.14.03.04.mov