[cp staging] Revert https://github.com/Expensify/App/pull/96942

[JS00001]

Explanation of Change

Reverts #96942

Fixed Issues

$ #98329
$ #98206

Tests

N/A

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

• Verify that no errors appear in the JS console

PR Author Checklist

N/A

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

[melvin-bot]

@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[situchan]

Was a conflict minor?

@MelvinBot please confirm this PR is the exact revert of #96942

[JS00001]

Was a conflict minor?

Yes, it was this line:

       previewHeaderText.unshift({text: date}, dotSeparator);

and an effect dependency array

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../MoneyRequestReportPreview/ReportPreviewHeader.tsx	100.00% <100.00%> (ø)
src/libs/TransactionPreviewUtils.ts	85.52% <82.75%> (-0.54%)	⬇️
...m/TransactionPreview/TransactionPreviewContent.tsx	77.34% <68.75%> (-4.96%)	⬇️
... and 10 files with indirect coverage changes

[MelvinBot]

Yes on both — with one nuance. This PR fully reverts the behavioral changes of #96942, and the conflict was minor. But it is not a byte-for-byte inverse of that PR — two benign differences remain, and one of them is exactly why there was a conflict.

Every functional change from #96942 is undone: the previewHeaderText → previewTypeText/previewStatusText/previewDateText split, the ReportPreviewDataContext/shouldShowCanceledStatus logic, the category/tag row rewrite (Folder/Tag icons, getCommaSeparatedTagNameWithSanitizedColons), and the restored isManagedCardTransaction/hasViolationsOfTypeNotice/isPartialHold/iouReportOwnerLogin logic all match the pre-#96942 state, in both TransactionPreviewContent.tsx and TransactionPreviewUtils.ts, plus both test files.

The two deviations from a pure git revert:

1. The conflict — correctly resolved. A later PR added dateFnsLocale (date localization) on top of refactor: align expense preview card metadata line with mobile row styling #96942, touching the same date-formatting code and function signature refactor: align expense preview card metadata line with mobile row styling #96942 changed. This revert keeps dateFnsLocale rather than reverting it — see TransactionPreviewUtils.ts:218 and :337. That's the right call: you don't want to also revert that unrelated later change. The conflict was small and localized to this date-format/dateFnsLocale overlap.

2. Cosmetic only. A handful of object literals come back reformatted to multi-line (Prettier), which weren't touched by refactor: align expense preview card metadata line with mobile row styling #96942 — e.g. the useOnyx(CARD_LIST, …) selector, the truncate(merchant, …) calls, infoCellsTextStyle, and dotSeparator/RBRMessage/displayDeleteAmountText. No behavior change.

How I verified

Compared the full diff of #98338 against the diff of #96942 line-by-line across all 5 touched files. ReportPreviewHeader.tsx and both test files are an exact inverse. TransactionPreviewContent.tsx and TransactionPreviewUtils.ts restore all of #96942's logic exactly, differing from a pure inverse only by (1) preserving the newer dateFnsLocale param + its use in formatWithUTCTimeZone, and (2) the cosmetic reformatting above.

Bottom line: safe to treat as the revert of #96942 — the conflict was minor and resolved correctly.

[github-actions]

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #98338.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6f63c631004-6078ea0-2ddb31e125daa2cece88c315730f5a2de8d78dd3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6f63c63-6078ea0-ba756d5cce641895c448fef1c9beb005a7a4218a/index.html

Web 🕸️
https://98338.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/JS00001 in version: 9.4.52-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

[OSBotify]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/JS00001 in version: 9.4.53-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 No help site changes required.

This PR reverts #96942 ("align expense preview card metadata line with mobile row styling"). Both the original change and this revert are purely cosmetic/layout changes to the expense (transaction) preview card — how the merchant, amount, date, category, tag, and cancelled-payment status are arranged and styled within the preview. No feature behavior, settings, tab names, button labels, or user-facing copy changed.

Expensify's help site articles under docs/articles document features and workflows, not the visual layout of preview cards. I searched docs/articles for any content describing the expense/transaction preview card layout (including category/tag display and cancelled-payment status) and found none, so there is nothing to update.

No draft help site PR was created.

[OSBotify]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.53-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android