Skip to content

Add a cleanup step for bootstrapper files to remove stale NUKE_ENTERPRISE_TOKEN handling#519

Open
ITaluone wants to merge 2 commits into
Fallout-build:mainfrom
ITaluone:feat/migration-cleanup-step
Open

Add a cleanup step for bootstrapper files to remove stale NUKE_ENTERPRISE_TOKEN handling#519
ITaluone wants to merge 2 commits into
Fallout-build:mainfrom
ITaluone:feat/migration-cleanup-step

Conversation

@ITaluone

@ITaluone ITaluone commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Closes: #518

Add a small cleanup step, which removes stale env var check for the NUKE_ENTERPRISE_TOKEN variable, which in return adds a special nuget source (which at best is stale and at worst non-existent).

  • Added direct cleanup tests
  • Additional MigrationsIntegrationTests

@IT-VBFK

IT-VBFK commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@dennisdoomen Should this go into the already existing RewriteBootstrapScriptsStep.cs or like this as dedicated step?

@dennisdoomen

Copy link
Copy Markdown
Collaborator

Should this go into the already existing RewriteBootstrapScriptsStep.cs or like this as dedicated step?

I would definitely make that a dedicated step.

@IT-VBFK

IT-VBFK commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Cool :)

@ITaluone
ITaluone force-pushed the feat/migration-cleanup-step branch 2 times, most recently from b361254 to e2cbe24 Compare July 20, 2026 19:34
@ITaluone

Copy link
Copy Markdown
Collaborator Author

Should now fit definitely :)

@ITaluone ITaluone added enhancement New feature or request target/vCurrent Targets the current version labels Jul 21, 2026
@ITaluone
ITaluone force-pushed the feat/migration-cleanup-step branch from e2cbe24 to 7c062b2 Compare July 21, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request target/vCurrent Targets the current version

Projects

None yet

3 participants