fix: rebuild the quick filter bar after a CalDAV refresh - #1293
Closed
unaimed wants to merge 1 commit into
Closed
Conversation
Fixes FossifyOrg#1292: after a CalDAV refresh, a calendar's new colour or name shows in the views but the quick filter bar keeps the old one; only clearing the app's data made it show the new one. Both refresh paths, updateCalDAVEvents() and calDAVChanged(), only called refreshViewPager(); the bar is rebuilt by setupQuickFilter(), as every other flow that changes calendars already does. Call it in both places. Tested with a foss debug build of this branch (main at d985d5e) on a Pixel 9a, Android 17, with DAVx5 and Nextcloud: the chip follows the views on the app's own refresh.
Contributor
|
Fossify accepts code contributions only for open issues labeled |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1292: after a CalDAV refresh, a calendar's new colour or name shows
in the views but the quick filter bar keeps the old one; only clearing the
app's data made it show the new one.
Both refresh paths, updateCalDAVEvents() and calDAVChanged(), only called
refreshViewPager(); the bar is rebuilt by setupQuickFilter(), as every
other flow that changes calendars already does. Call it in both places.
Tested with a foss debug build of this branch (main at d985d5e) on a
Pixel 9a, Android 17, with DAVx5 and Nextcloud: the chip follows the views
on the app's own refresh.