Fix: Local Playlist doesn't show upcoming premieres if 'hide upcoming premieres' is enabled#9320
Fix: Local Playlist doesn't show upcoming premieres if 'hide upcoming premieres' is enabled#9320Shadorc wants to merge 2 commits into
Conversation
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
8253f68 to
414400a
Compare
|
I can't test the online playlist case until playlist handling fixed (which I will work on soon |
PikachuEXE
left a comment
There was a problem hiding this comment.
Online playlist tested with #9325 merged
Last reviewer plz approve after that one merged
There was a problem hiding this comment.
Did same as Pika
For testing public playlist:
- Go to https://www.youtube.com/playlist?list=PLGm6__WNWiw6_rWkLP1i0UuQq7QzYwo8e
- Last entry in list is premiere vid
This is a regression test because the setting didnt affect public playlists. Meaning premiere video in public playlist is available whether the setting is enabled or not
|
Last reviewer please only approve after #9325 merged~ |
wasnt supposed to hit approve yet so dismissing to make sure this doesnt go in before #9325
Head branch was pushed to by a user without write access
414400a to
0439ef2
Compare
Pull Request Type
Related issue
closes #8261
Description
I've used the same pattern as
useChannelsHiddenPreference.The behavior is different when the window is narrowed because grid view uses
FtListLazyWrapperwhich implements 'hide upcoming premieres' preference whereas list view usesFtListVideoNumberedwhich does not take into account the setting.Testing
Local Playlist
Public Playlist