Add limit the number of videos displayed for each channel should be set to a max of 15 when RSS is enabled - #9327
Conversation
|
I think it should remember the user's last value, while the settings are linked, it still is technically a separate setting. Although maybe if the value is already at the max, it could be safely assumed the user would like it maximized either way? It also makes it clearer the maximum value has changed cap-2026-06-27_16.25.21.mp4 |
|
Behaviour explained and shown in screencap seems fine to me, so lets go with that |
Head branch was pushed to by a user without write access
|
Oh hmm lets say i deliberately choose to only see 20 (or anything above 15) without rss. Now i enable/disable rss and it will jump to 30. Isnt that undesired? |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
Just getting around to this again. Still deciding what should be the default action of the slider. Maybe it could remember the last selected value, but not sure if that just adds unnecessary complexity? |
|
Remembering the last value seems the more user friendly, but also the more complex to implement |
|
@PikachuEXE @absidue thoughts? |
|
I don't even understand why there are 2 values for RSS on/off... |
|
Because YouTube's RSS feeds contain 15 videos whereas one page in the API responses for the channel videos/live/shorts channels tabs contain 30 videos. |
|
I think it's fine to just use current value when limit 15 > 30 |
|
So i think that my suggestion in #9327 (review) added unintended complexity, Maybe we should revert to previous state? |
This reverts commit 7758ba5.
Head branch was pushed to by a user without write access
|
Yeah, I think it's best to revert it. I don't see it being a big issue either way and this way we avoid added complexity. |
Pull Request Type
Related issue
closes #8105
Description
Updates the UI so that when fetching feeds via RSS is enabled, the max video slider value is capped at 15 (technical limitation of RSS feed fetching)
Testing
Go to Settings -> Subscription
Ensure 'Limit the number of videos displayed for each channel' is enabled
Toggle 'Fetch feeds from RSS' and change the value slider
See what the limit is 15 when RSS is enabled and the limit is 30 when RSS is disabled
In all cases, confirm the number of videos displayed on the Subscription page matches the value slider
Additional context
Was unsure if the RSS disabled/enabled values should be set as variables, if anyone has feedback on this?