feat: expose PR comment id on build API - #240
Merged
Merged
Conversation
Adds commentId to the pullRequest object returned by GET /api/v2/builds/{uuid}
so clients can link directly to Lifecycle's mission control comment on GitHub.
Also marks commentId required (nullable) in the OpenAPI schema, matching how other always-selected nullable columns are documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
commentIdto thepullRequestobject returned byGET /api/v2/builds/{uuid}.Why
The UI wants to let users jump straight from a build to Lifecycle's status comment on the PR. That comment's GitHub ID is already tracked on the
pull_requeststable but wasn't exposed over the API.Verifying Changes