Fix issue 20073 with diff suppress#17283
Open
faustroxas wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Open
Fix issue 20073 with diff suppress#17283faustroxas wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
faustroxas wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
roaks3
reviewed
Apr 24, 2026
| // actual organization number. Since purpose_data is immutable, if the old value | ||
| // (from state) exists and is non-empty, we suppress the diff to avoid | ||
| // unnecessary replacements after import. | ||
| func TagKeyPurposeDataDiffSuppress(k, old, new string, d *schema.ResourceData) bool { |
Contributor
There was a problem hiding this comment.
If I'm understanding correctly, wouldn't this also prevent someone from changing purpose_data in their config (and getting a plan to replace the tag key)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #20073
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.