Skip to content

fix: repair settings and racy labeling test found during analysis - #3374

Open
Vladyslavleiner wants to merge 1 commit into
Graphify-Labs:v8from
Vladyslavleiner:fix/repair-settings-and-racy-label-test
Open

fix: repair settings and racy labeling test found during analysis#3374
Vladyslavleiner wants to merge 1 commit into
Graphify-Labs:v8from
Vladyslavleiner:fix/repair-settings-and-racy-label-test

Conversation

@Vladyslavleiner

Copy link
Copy Markdown
Contributor

Summary

Fixes found while running the full test suite and auditing settings.

Changes

  1. tests/test_labeling.py — pin max_concurrency=1 in the batch-order test so the recorded batch sizes are deterministic. The default concurrent path (Feature request: --max-concurrency and --batch-size for cluster-only / label #1390) can complete batches out of order, making assert calls == [100, 100, 50] flaky (observed [100, 50, 100] on Python 3.14).

  2. SECURITY.md — bump the supported-versions table from 0.3.x to 0.9.x (the project is at 0.9.55).

  3. uv.lock — regenerate so the pinned graphifyy version matches pyproject (0.9.53 -> 0.9.55).

Verification

  • uv lock --check passes
  • uv sync --frozen passes
  • Full suite: 5347 passed, 88 skipped (after git fetch --unshallow and installing extras)

@graphify-labs graphify-labs Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphify reviewed this change.

Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).


Graphify review — findings

Bumps the security policy's supported versions from 0.3.x to 0.9.x and the project version to 0.9.55. Pins test_label_communities_batches_when_over_batch_size to max_concurrency=1 so batch calls record in deterministic order, with the concurrent ordering covered separately. Regenerates uv.lock with reworked dependency markers.

No blocking issues surfaced. 3 lower-confidence candidates did not survive cross-model review.

Analysis details — impact, health, verification

Impact & health

Graphify review

Impact — 84 functions depend on the 84 functions this change touches.

Health — grade A; no new coupling hotspots.

Verification — 84 functions in the blast radius were not formally verified this run (proofs are advisory here).

Gate & verification

graphify gate

PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 84 function(s) in the blast radius were not formally verified this run

- tests/test_labeling.py: pin max_concurrency=1 in the batch-order test so
  the recorded batch sizes are deterministic (default concurrent path can
  complete batches out of order)
- SECURITY.md: bump supported versions to 0.9.x (table was stale at 0.3.x)
- uv.lock: regenerate to match graphifyy 0.9.55 (was pinned at 0.9.53)
safishamsi pushed a commit that referenced this pull request Sep 7, 2026
…erministic

The assertion recorded the order batches reached their LLM call inside worker
threads, which is nondeterministic; the product merges by cid on the main
thread and concurrency equivalence is covered by a sibling test. Takes only the
flaky-test fix from #3374 (its SECURITY.md/uv.lock changes are handled
separately).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant