Fix dropdown menus spawning offset in scrolled panels, a regression from upgrading to Svelte 5.54#4047
Merged
Fix dropdown menus spawning offset in scrolled panels, a regression from upgrading to Svelte 5.54#4047
Conversation
…rom upgrading to Svelte 5.54 Regression introduced in #3933 by upgrading from Svelte 5.47.1 to 5.54.1
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the FloatingMenu component to use CSS custom properties for positioning and border-radius styling instead of direct inline style manipulation. This change avoids recursive afterUpdate calls and prevents Svelte from overwriting manual style updates. A review comment suggests that these custom properties should be cleared unconditionally at the start of the positioning logic to prevent stale styles, as some properties are currently only reset under specific conditions or not at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression introduced in #3933 by upgrading from Svelte 5.47.1 to 5.54.1