AB#605 reactivation of personalization#5870
Merged
Merged
Conversation
Name property is used as translation id, whereas label is actual text content
- roundex box, not pill button - lighter background overlay - add highlight aura
It is not shown if user has set personalization off.
VillePihlava
left a comment
VillePihlava
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just one small thing (and the z-index stuff if thats still relevant)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A modal asks if personalization history should be kept or emptied. Opens only if there is existing history.
This PR also adds feedback element as a teaser to itinerary detail view of non-logged users which have not yet turned personalization off.
Some components modernized as well.