Skip to content

🧹 Remove unused has_open_entries in slop_ledger#3117

Closed
Hmbown wants to merge 1 commit into
mainfrom
fix-unused-has-open-entries-5836367800244141658
Closed

🧹 Remove unused has_open_entries in slop_ledger#3117
Hmbown wants to merge 1 commit into
mainfrom
fix-unused-has-open-entries-5836367800244141658

Conversation

@Hmbown

@Hmbown Hmbown commented Jun 12, 2026

Copy link
Copy Markdown
Owner

🎯 What: Removed the has_open_entries function from crates/tui/src/slop_ledger.rs and simplified its call sites.
💡 Why: The function was unused dead code in practice because completion_gate_summary() performs the exact same check internally before returning anything. Using completion_gate_summary directly is simpler and removes redundancy.
Verification: Verified by running cargo check, cargo fmt --check, cargo clippy, and cargo test slop_ledger - all checks passed successfully.
Result: Improved code maintainability by deleting a redundant function and making code shorter and simpler.


PR created automatically by Jules for task 5836367800244141658 started by @Hmbown

Co-authored-by: Hmbown <101357273+Hmbown@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the completion gate logic by removing the redundant has_open_entries method and its usages across the codebase, directly relying on completion_gate_summary instead. There are no review comments to evaluate, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Hmbown Hmbown added this to the v0.8.64 milestone Jun 13, 2026
@Hmbown

Hmbown commented Jun 15, 2026

Copy link
Copy Markdown
Owner Author

Closing as part of cleaning up stale auto-generated PRs from the v0.8.64/v0.8.65 milestones. If any of this work is still wanted it can be reopened or re-landed.

@Hmbown Hmbown closed this Jun 15, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as part of cleaning up stale auto-generated PRs from the v0.8.64/v0.8.65 milestones. If any of this work is still wanted it can be reopened or re-landed.

Understood. Acknowledging that this PR is being closed as part of cleanup and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant