🧹 Remove unused prompt_persist module#3119
Conversation
The prompt_persist module contained entirely unused functions annotated with #[allow(dead_code)]. Removing it reduces maintenance burden. Co-authored-by: Hmbown <101357273+Hmbown@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the prompt_persist module from the TUI crate, deleting the file entirely and removing its declaration from main.rs. This module previously handled cross-session persistence for the system prompt's base section. As there are no review comments, I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
v0.8.59 triage: a test merge of this PR into |
Understood. Acknowledging that this change is already landed in the release branch and the PR can be closed once it reaches main. Stopping work on this task. |
Co-authored-by: Hmbown <101357273+Hmbown@users.noreply.github.com>
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Closing as part of cleaning up stale auto-generated PRs from the v0.8.64/v0.8.65 milestones. If any of this work is still wanted it can be reopened or re-landed. |
Understood. Acknowledging that this PR is being closed as part of stale auto-generated PR cleanup and stopping work on this task. |
1 participant
🎯 What: Removed the
crates/tui/src/prompt_persist.rsfile and its declaration incrates/tui/src/main.rs.💡 Why: The entire module consisted of functions (like
load_cached_base_section,save_cached_base_section, etc.) that were annotated with#[allow(dead_code)]and were demonstrably not used anywhere else in the application. Removing dead code reduces the size of the codebase, removes potential confusion for future developers, and lowers maintenance burden.✅ Verification: Verified by running
cargo checkandcargo test -p codewhale-tuiwhich compiled successfully, confirming no active part of the codebase relied on this module.✨ Result: Improved codebase cleanliness and readability without any change to application behavior.
PR created automatically by Jules for task 4989335663632198223 started by @Hmbown