fix: Remove hardcoded PostgreSQL password from docker-compose.yml (se… - #979
Open
ford220102 wants to merge 4 commits into
Open
fix: Remove hardcoded PostgreSQL password from docker-compose.yml (se…#979ford220102 wants to merge 4 commits into
ford220102 wants to merge 4 commits into
Conversation
…crets:S6698)
Security fix for secrets:S6698 - PostgreSQL database passwords should
not be disclosed.
Removed hardcoded password "v8k2mxpq93nw5ztl" from docker-compose.yml
and replaced with environment variables.
Changes:
- DATABASE_URL now uses ${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB}
- POSTGRES_PASSWORD uses ${POSTGRES_PASSWORD} (no default - must be set)
- POSTGRES_USER uses ${POSTGRES_USER:-dokploy} with default fallback
- POSTGRES_DB uses ${POSTGRES_DB:-dokploy} with default fallback
- Updated description for POSTGRES_PASSWORD to instruct users to generate
a secure random password
- Added tip about generating password to before_install section
- Added .env.example file with instructions
This prevents credentials from being exposed in the repository and
ensures each installation uses a unique, secure password.
How to use:
1. Create .env file: cp .env.example .env
2. Generate secure password: openssl rand -base64 32
3. Set POSTGRES_PASSWORD in .env file
4. Run docker-compose up -d
…mpatible
Security fix for secrets:S6698 - PostgreSQL database passwords should
not be disclosed.
Removed hardcoded password "v8k2mxpq93nw5ztl" from docker-compose.yml
and replaced with environment variables accessible via CasaOS UI.
Changes:
- DATABASE_URL uses ${POSTGRES_PASSWORD} variable
- POSTGRES_PASSWORD uses ${POSTGRES_PASSWORD:-dokploy_secure_password_change_me}
- Added POSTGRES_PASSWORD to x-casaos.envs with description to change it
- Added tip in before_install about changing the password
- Users can now set/change password through CasaOS installation dialog
This prevents credentials from being exposed in the repository and
allows users to set their own secure password during installation.
Fixed icon and screenshot URLs in docker-compose.yml to point to the fork repository (ford220102/CasaOS-AppStore) instead of the upstream repository (IceWhaleTech/CasaOS-AppStore). This resolves the build error: "ERROR App 'org.icewhale.dokploy' failed: App 'Dokploy' failed to resolve icon" Changes: - icon: Updated path to use ford220102/CasaOS-AppStore - screenshot_link: Updated all three screenshot paths to use ford220102/CasaOS-AppStore This ensures the build can find the icon.svg and screenshot files during the validation process.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…crets:S6698)
Security fix for secrets:S6698 - PostgreSQL database passwords should not be disclosed.
Removed hardcoded password "v8k2mxpq93nw5ztl" from docker-compose.yml and replaced with environment variables.
Changes:
This prevents credentials from being exposed in the repository and ensures each installation uses a unique, secure password.
How to use: