Fix dpnp.tensor.expm1 handling of complex(+-0, 0) #2926
Merged
Conversation
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2926/index.html |
antonwolfy
reviewed
May 19, 2026
Collaborator
|
coverage: 78.242%. remained the same — fix_expm1_complex into master |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_53 ran successfully. |
Contributor
Author
|
@ndgrigorian this is RFR |
github-actions Bot
added a commit
that referenced
this pull request
May 27, 2026
This PR proposes to fix issue #2878 where `dpnp.tensor.expm1(complex(-0.0, 0.0))` returned `-0.0 + 0.0j` on CPU instead of `0.0 + 0.0j` as required by the Array API specification The fix adds an explicit special-case branch for `complex(±0, 0)` in `expm1.hpp` so CPU and GPU behavior are now consistent and compliant with the specification. Also `test_expm1_special_cases` test was extended to cover `complex(-0.0, 0.0)` 87510bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to fix issue #2878 where
dpnp.tensor.expm1(complex(-0.0, 0.0))returned-0.0 + 0.0jon CPU instead of0.0 + 0.0jas required by the Array API specificationThe fix adds an explicit special-case branch for
complex(±0, 0)inexpm1.hppso CPU and GPU behavior are now consistent and compliant with the specification.Also
test_expm1_special_casestest was extended to covercomplex(-0.0, 0.0)