Correct TrackingEvents parent: NonLinearAds, not NonLinear (fixes vast#55) - #2
Open
aleksUIX wants to merge 1 commit into
Conversation
Section 3.14.2 listed the parents of TrackingEvents as Linear, NonLinear, and Companion. The NonLinear entry is wrong: tracking for nonlinear creative lives on the NonLinearAds container, not on the individual NonLinear element. This matches section 3.12 of this same document (NonLinearAds sub-elements: NonLinear TrackingEvents; the 3.12.1 NonLinear sub-element list has no TrackingEvents), the vast_4.2 XSD (TrackingEvents children on Linear_Base_type, CompanionAd_type, and both NonLinearAds elements; none on NonLinear), and the VAST 2.0/3.0 schemas. Applied to 4.3.md and 4.4.md; also drops a stray comma in the same sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes InteractiveAdvertisingBureau/vast#55.
Problem
Section 3.14.2 in both
4.3.mdand4.4.mdlists the parents of<TrackingEvents>as Linear, NonLinear, Companion. The NonLinear entry is incorrect: tracking for nonlinear creative hangs off the<NonLinearAds>container, not the individual<NonLinear>element. As the issue notes, this error carried over from the 4.3 PDF.Evidence
NonLinear TrackingEvents, and its prose says the container holds "the<NonLinear>creative files and tracking resources". Section 3.12.1's NonLinear sub-element list contains no TrackingEvents.vast_4.2.xsd(in thevastrepo):TrackingEventschildren exist onLinear_Base_type,CompanionAd_type, and both the InLine and WrapperNonLinearAdselements; theNonLineartype has none.I maintain a VAST validator (vastlint) whose structural model was built against the XSDs and this spec; this contradiction between 3.12 and 3.14.2 is one of the spots where the prose and the schema disagree and implementers guess.
Change
Four lines across
4.3.mdand4.4.md, section 3.14.2 only:| Parent | Linear NonLinearAds Companion |Section 3.14.3's note that tracking event values "differ for
<Linear>,<NonLinear>, and<Companion>" is left untouched, since that sentence is about metric categories per creative type, not element parentage.