add additional hitograms to the plugin to show the timing of the PSC and - #1145
Merged
Conversation
PS counters with respect to the RF time. Also the plugin explicilty looks for PS trigger events DL1Trigger = 0x8 Also changed to code to use the TOF RF time which has the best timing resolution rather than "PSC": vector <const DRFTime*> rfTimes; event->Get(rfTimes);
|
Test status for this pull request: SUCCESS Summary: summary.txt Build log: make_beni_change_PS_timing.log |
Contributor
Author
|
typo in histogram bin definition should be set to 150 but is set at 151 for the two histograms: |
|
Test status for this pull request: SUCCESS Summary: summary.txt Build log: make_beni_change_PS_timing.log |
nsjarvis
approved these changes
Jun 25, 2026
nsjarvis
left a comment
nsjarvis
left a comment
Contributor
There was a problem hiding this comment.
This PR adds useful histograms, I'll try to attach an example
Contributor
|
Example: psHITtiming1 histo for run 133095 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS counters with respect to the RF time.
Also the plugin explicilty looks for PS trigger events DL1Trigger = 0x8 Also changed to code to use the TOF RF time which has the best timing resolution rather than "PSC":
vector <const DRFTime*> rfTimes;
event->Get(rfTimes);