Skip to content

Bounty payment logic fixes#4395

Open
Lezek123 wants to merge 3 commits into
Joystream:mainnetfrom
Lezek123:bounty-payment-logic-fixes
Open

Bounty payment logic fixes#4395
Lezek123 wants to merge 3 commits into
Joystream:mainnetfrom
Lezek123:bounty-payment-logic-fixes

Conversation

@Lezek123

@Lezek123 Lezek123 commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Addresses #4192

┆Issue is synchronized with this Asana task by Unito

@vercel

vercel Bot commented Oct 20, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
pioneer-testnet ⬜️ Ignored (Inspect) Nov 23, 2022 at 6:45AM (UTC)

@bedeho

bedeho commented Oct 26, 2022

Copy link
Copy Markdown
Member

We are merging this into carthage, right?, but just filtering out?

@Lezek123

Copy link
Copy Markdown
Contributor Author

We are merging this into carthage, right?, but just filtering out?

Sure, we can merge it to Carthage, create_bounty call is filtered out in Carthage

@bedeho

bedeho commented Nov 17, 2022

Copy link
Copy Markdown
Member

What is status of this.

@Lezek123

Copy link
Copy Markdown
Contributor Author

What is status of this.

Just needs to be reviewed I think, who should I assign?

@Lezek123 Lezek123 changed the base branch from carthage to mainnet November 17, 2022 16:47
@bedeho

bedeho commented Nov 17, 2022

Copy link
Copy Markdown
Member

@ignazio-bovo

dobertRowneySr
dobertRowneySr previously approved these changes Nov 22, 2022

@dobertRowneySr dobertRowneySr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I just left a small comment

Comment thread runtime-modules/bounty/src/actors.rs Outdated
Co-authored-by: Ignazio Bovo <bovoignazio.dev@gmail.com>

@dobertRowneySr dobertRowneySr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants