Skip to content

add option to draw an M circle in the Nyquist plot#856

Merged
baggepinnen merged 3 commits into
masterfrom
M-circles
May 14, 2026
Merged

add option to draw an M circle in the Nyquist plot#856
baggepinnen merged 3 commits into
masterfrom
M-circles

Conversation

@baggepinnen
Copy link
Copy Markdown
Member

No description provided.

@JuliaControlBot
Copy link
Copy Markdown

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2023

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.57%. Comparing base (2e102ad) to head (eb6b030).

Files with missing lines Patch % Lines
lib/ControlSystemsBase/src/plotting.jl 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage   91.54%   91.57%   +0.02%     
==========================================
  Files          42       42              
  Lines        5609     5623      +14     
==========================================
+ Hits         5135     5149      +14     
  Misses        474      474              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Rename keyword to avoid clashing with the classical Hall M-circle
  terminology already used by Mt_circles.
- Document the symmetric gain margin [(M-1)/M, M/(M-1)] and the
  phase margin atan((2M-1)/(2M(M-1))) guarantees.
- Default to Float64[] for type stability.
- Validate M > 1 (avoids the M = 1 singularity and M < 1 sign flip).
@baggepinnen baggepinnen marked this pull request as ready for review May 14, 2026 12:51
@baggepinnen baggepinnen merged commit 75801d6 into master May 14, 2026
5 checks passed
@baggepinnen baggepinnen deleted the M-circles branch May 14, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants