compress printing for very large statespace models#965
Merged
Conversation
|
This is an automated message. |
Move the D-matrix println back outside `if nstates(sys) > 0` so pure feedthrough systems (state dimension 0) still show D. Add tests covering the new compressed format for large A/B/C/D, the zero-D shortcut, and the mixed case (large A with small B/C/D). Update the four existing print test strings to drop the trailing blank line that the previous `println(..., "\n")` produced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Same trailing-blank-line drop as the existing StateSpace print tests — these composite types embed the StateSpace show output. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Restore the trailing "\n" argument on the D println so the blank line between D and the time-domain line is preserved (downstream packages may depend on this output format). Both the small-matrix and the new compressed branches now emit the blank line. Test expectations for the 4 existing StateSpace tests, the 2 composite-type tests, and the 2 new compressed-matrix tests updated accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
==========================================
- Coverage 92.78% 91.57% -1.22%
==========================================
Files 41 42 +1
Lines 4975 5624 +649
==========================================
+ Hits 4616 5150 +534
- Misses 359 474 +115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.