Skip to content

fix(model-selector): show accurate free and training indicators#3943

Merged
chrarnoldus merged 8 commits into
mainfrom
fix/model-selector-metadata-badges
Jun 11, 2026
Merged

fix(model-selector): show accurate free and training indicators#3943
chrarnoldus merged 8 commits into
mainfrom
fix/model-selector-metadata-badges

Conversation

@chrarnoldus

@chrarnoldus chrarnoldus commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Model selectors now present Free and prompt-training indicators as independent model properties across the web and mobile apps.

  • A model displays the Free badge only when its isFree metadata is true.
  • A model displays the book indicator only when mayTrainOnYourPrompts is true, including paid models that may train on prompts.
  • Web and mobile selector option mappings retain both fields so every affected model picker applies the same rules.
  • Existing indicator styling, sizing, accessibility behavior, and upstream model metadata construction remain unchanged.

Verification

  • Manual UI verification was not performed because local app services were not started.

Visual Changes

No screenshots captured. The existing visuals are unchanged; the indicators now appear for the correct models.

Reviewer Notes

The expected combinations are:

isFree mayTrainOnYourPrompts Indicators
true true Free badge and book
true false or absent Free badge only
false or absent true Book only
false or absent false or absent Neither

Formatting, web and mobile typechecks, changed-file lint, and the mobile test suite passed. Targeted web Jest tests could not run because the local Postgres test database was unavailable.

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@chrarnoldus chrarnoldus self-assigned this Jun 10, 2026
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@kilo-code-bot

kilo-code-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The new commit (37a89b1a4) adds only a minor visual fix: FreeModelDataIcon gains a compact prop (defaulting to false) and is passed compact inside ModelMetadataBadges to render a slightly smaller icon (h-3 w-3) in list rows. No logic issues, security concerns, or bugs were introduced.

Files Reviewed (26 files)
  • apps/mobile/src/app/(app)/agent-chat/model-picker.tsx
  • apps/mobile/src/components/agents/model-selector.tsx
  • apps/mobile/src/lib/free-model-data-disclosure.test.ts
  • apps/mobile/src/lib/free-model-data-disclosure.ts
  • apps/mobile/src/lib/hooks/use-available-models.ts
  • apps/web/src/app/(app)/claw/components/SettingsTab.tsx
  • apps/web/src/app/(app)/claw/hooks/useClawModelOptions.ts
  • apps/web/src/app/(app)/cloud/webhooks/[triggerId]/EditWebhookTriggerContent.tsx
  • apps/web/src/app/(app)/cloud/webhooks/new/CreateWebhookTriggerContent.tsx
  • apps/web/src/app/(app)/gastown/[townId]/rigs/[rigId]/settings/RigSettingsPageClient.tsx
  • apps/web/src/app/(app)/gastown/[townId]/settings/TownSettingsPageClient.tsx
  • apps/web/src/app/(app)/gastown/onboarding/OnboardingStepModel.tsx
  • apps/web/src/components/app-builder/AppBuilderChat.tsx
  • apps/web/src/components/app-builder/AppBuilderLanding.tsx
  • apps/web/src/components/cloud-agent-next/NewSessionPanel.tsx
  • apps/web/src/components/cloud-agent-next/hooks/useOrganizationModels.ts
  • apps/web/src/components/cloud-agent/CloudSessionsPage.tsx
  • apps/web/src/components/cloud-agent/hooks/useOrganizationModels.ts
  • apps/web/src/components/cloud-agent/profile-editor/KiloCommandsTab.tsx
  • apps/web/src/components/cloud-agent/profile-editor/ProfileAgentsTab.tsx
  • apps/web/src/components/integrations/DiscordIntegrationDetails.tsx
  • apps/web/src/components/integrations/LinearIntegrationDetails.tsx
  • apps/web/src/components/integrations/SlackIntegrationDetails.tsx
  • apps/web/src/components/shared/ModelCombobox.tsx ✅ new compact icon size fix
  • apps/web/src/components/shared/free-model-data-disclosure.test.ts
  • apps/web/src/components/shared/free-model-data-disclosure.ts
  • apps/web/src/lib/ai-gateway/models.ts
  • apps/web/src/lib/ai-gateway/providers/kilo-exclusive-model.ts ✅ previous issue resolved
  • apps/web/src/lib/ai-gateway/providers/kilo-exclusive-model.test.ts
  • apps/web/src/lib/ai-gateway/providers/openrouter/index.ts

Reviewed by claude-4.6-sonnet-20260217 · 1,026,999 tokens

Review guidance: REVIEW.md from base branch main

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@chrarnoldus chrarnoldus changed the title fix(model-selector): respect explicit model metadata fix(model-selector): respect model badge metadata Jun 10, 2026
chrarnoldus and others added 5 commits June 10, 2026 20:18
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@chrarnoldus chrarnoldus changed the title fix(model-selector): respect model badge metadata fix(model-selector): show accurate free and training indicators Jun 11, 2026
@chrarnoldus

chrarnoldus commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

These "Stealth" models now also show the training indicator rather than just free models.

@chrarnoldus chrarnoldus merged commit 7eae40d into main Jun 11, 2026
19 checks passed
@chrarnoldus chrarnoldus deleted the fix/model-selector-metadata-badges branch June 11, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants