🔒 Secure web intents using Custom Tabs#49
Conversation
Replaced implicit `ACTION_VIEW` intents with `CustomTabsIntent` for HTTP/HTTPS web links in `MainActivity`. This mitigates intent hijacking risks where malicious apps could intercept generic view actions and expose user data or conduct phishing attacks. - Added `androidx.browser:browser:1.8.0` to `app/build.gradle.kts`. - Updated all relevant `Intent.ACTION_VIEW` usages targeting web URLs. - Retained `market://` links as standard intents, as they are intentionally meant for app stores.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: This PR fixes a security vulnerability where several web URLs were opened using implicit
Intent.ACTION_VIEWintents.🛡️ Solution:
androidx.browser:browserdependency toapp/build.gradle.kts.Intent(Intent.ACTION_VIEW, ...)withCustomTabsIntent.Builder().build().launchUrl(...)for allhttp://andhttps://links inMainActivity.kt.market://links as standard intents to allow handling by installed app stores (like Google Play).This ensures that web links open securely within a Chrome Custom Tab, or the default configured browser, protecting the user from intent interception attacks.
PR created automatically by Jules for task 11572267991238799803 started by @LeanBitLab