fix(parquet): pass storage_options as **kwargs to fsspec.filesystem, fix mutable default args#837
Open
Tejas5405 wants to merge 1 commit into
Open
Conversation
… fix mutable defaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
index_parquet_dataset()crashes with aTypeErrorwhen passingstorage_optionsfor S3 or any cloud filesystem:The bug is in
src/litdata/utilities/parquet.pyline 153 —storage_options(adict) is unpacked with*(which iterates keys as positional args) instead of**(which passes key-value pairs as keyword args):Additional fixes
Two places used a mutable default argument (
{}) forstorage_options, which is a well-known Python antipattern — a single dict is shared across all calls if not overridden:Fixed in
ParquetCloudIndexer.__init__(line 81) andget_parquet_indexer_cls()(line 307). The existingNone→{}guard in the base class handles the empty-dict default correctly.Reproduction
Closes #835