Skip to content

Add isMalicious expansion and hover module - #798

Merged
adulau merged 2 commits into
MISP:mainfrom
hexablob:feat/ismalicious-module
Aug 21, 2026
Merged

Add isMalicious expansion and hover module#798
adulau merged 2 commits into
MISP:mainfrom
hexablob:feat/ismalicious-module

Conversation

@hexablob

@hexablob hexablob commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Closes #797

Description

Adds misp_modules/modules/expansion/ismalicious.py, an expansion + hover module that calls GET https://api.ismalicious.com/check with X-API-KEY.

Input types: ip-src, ip-dst, hostname, domain, url, domain|ip

Config: api_key (required), api_url (optional, default https://api.ismalicious.com)

Output: a text attribute summarizing malicious, risk score, categories, and source count. Hover and expansion share the same handler.

No extra Python dependencies (requests is already used by other expansion modules). Expansion modules in this directory are auto-discovered.

Docs: https://ismalicious.com/integrations/misp

@hexablob

Copy link
Copy Markdown
Contributor Author

Ready for review. Expansion + hover module, auto-discovered under misp_modules/modules/expansion/. Uses requests only. Config: api_key (required), api_url (optional).

@adulau

adulau commented Aug 17, 2026

Copy link
Copy Markdown
Member

Can you update the module to pass the CI? Thank you very much.

hexablob and others added 2 commits August 19, 2026 15:07
Co-authored-by: Cursor <cursoragent@cursor.com>
The previous CI run failed on the unrelated BTC scam check live query;
this rebases onto main (where that test is skipped in LiveCI) and covers
the new module with mocked requests like the other recent expansions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@hexablob
hexablob force-pushed the feat/ismalicious-module branch from c16f0b3 to 8c3a345 Compare August 19, 2026 13:12
@hexablob

hexablob commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Definitely updated it @adulau, rebased onto current main (the previous CI failure was test_btc_scam_check, now skipped under LiveCI) and updated the module to match the other expansions:

  • use check_input_attribute / standard_error_message from the expansion package
  • return misp_standard results via PyMISP
  • add mocked unit tests in tests/test_ismalicious.py

Local flake8 + those six tests pass. CI should go green on this push.

@adulau
adulau merged commit 27bc09f into MISP:main Aug 21, 2026
7 checks passed
@adulau

adulau commented Aug 21, 2026

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add isMalicious expansion and hover module

2 participants