MDEV-36792: UBSAN load of null pointer and Assertion b == &type_handler_row || b == &type_handler_null in Arg_comparator::set_cmp_func when using ROW()#4988
Open
raghunandanbhat wants to merge 1 commit into11.8from
Conversation
…ler_row || b == &type_handler_null` in `Arg_comparator::set_cmp_func when using ROW()` Problem: When a stored function returning `ROW` type is used as a `ROW` field and comapred against a non-ROW field, server crashes trying to aggregate types for comaprison in- `Type_collection_row::aggregate_for_comparison`. for example: CREATE FUNCTION f() RETURNS ROW TYPE OF t RETURN 1; SELECT ROW(f(),1)=ROW(1,1) AS eq; Fix: Convert assertions in `Type_collection_row::aggregate_for_comparison` into a condition and return `NULL` if an invalid type combination is detected.
raghunandanbhat
force-pushed
the
11.8-mdev-36792
branch
from
a882260 to
093be2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes MDEV-36792
Problem:
When a stored function returning
ROWtype is used as aROWfield and comapred against a non-ROW field, server crashes trying to aggregate types for comparison in-Type_collection_row::aggregate_for_comparison.for example:
Fix:
Convert assertions in
Type_collection_row::aggregate_for_comparisoninto a condition and returnNULLif an invalid type combination is detected.