refactor(cli): complete ACBRA compatibility facade - #85
Draft
Maximooch wants to merge 10 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Maximooch
force-pushed
the
codex/cli-acbra
branch
from
August 8, 2026 00:10
f03e8c7 to
d08dd50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
penguin/cli/cli.pyfrom 5,213 lines to 1,045 linesfeatures.mdWhy
The entry point still owned thousands of lines of unrelated command registration and captured mutable globals, making help, monkeypatching, and future config work fragile.
Impact
cli.pyis now a composition/compatibility facade. Commands retain their public names, options, and legacy callable exports while their registration lives with the relevant surface.Validation
tests/: 2,375 passed, 3 skipped, 113 deselected; four unrelated failures documentedmisc/tests: blocked by stalepenguin.penguin.tools.core.old_memory_searchimportStack: #82 → startup PR → runtime PR → this PR.
CI note
The two Link-provider jobs and Python 3.9 goal job are inherited unchanged from base PR #82. Python 3.12 goal, TUI, docs, and deployment checks pass.