Skip to content

refactor(cli): complete ACBRA compatibility facade - #85

Draft
Maximooch wants to merge 10 commits into
codex/cli-acbra-runtimefrom
codex/cli-acbra
Draft

refactor(cli): complete ACBRA compatibility facade#85
Maximooch wants to merge 10 commits into
codex/cli-acbra-runtimefrom
codex/cli-acbra

Conversation

@Maximooch

@Maximooch Maximooch commented Aug 8, 2026

Copy link
Copy Markdown
Owner

What changed

  • extracts agent, config/permissions, skills/MCP, project/task, coordination, and diagnostic Typer registration into focused binders
  • keeps compatibility exports and provider-free command-group help contracts
  • reduces penguin/cli/cli.py from 5,213 lines to 1,045 lines
  • records ACBRA verification evidence
  • adds a provenance-aware configuration/capability follow-up plan informed by features.md

Why

The entry point still owned thousands of lines of unrelated command registration and captured mutable globals, making help, monkeypatching, and future config work fragile.

Impact

cli.py is now a composition/compatibility facade. Commands retain their public names, options, and legacy callable exports while their registration lives with the relevant surface.

Validation

  • CLI-focused suite: 134 passed
  • repository tests/: 2,375 passed, 3 skipped, 113 deselected; four unrelated failures documented
  • misc/tests: blocked by stale penguin.penguin.tools.core.old_memory_search import
  • compileall passed; purpose-built extracted services pass Ruff
  • wheel and sdist built successfully
  • isolated installed-wheel smoke passed for root, config, project, and agent help

Stack: #82 → startup PR → runtime PR → this PR.

CI note

The two Link-provider jobs and Python 3.9 goal job are inherited unchanged from base PR #82. Python 3.12 goal, TUI, docs, and deployment checks pass.

@vercel

vercel Bot commented Aug 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
penguin Ready Ready Preview Aug 8, 2026 12:10am

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 47b0ae05-b842-4a82-9da2-c26d852a79de

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant