chore: add platform and tool orchestrator#31
Conversation
| () => config.sessionManager.getPage(), | ||
| config.sessionManager, | ||
| )) | ||
| : undefined; |
There was a problem hiding this comment.
Won't this cause issues for mobile platform?
If we are launching (first tool) with platform ios, at that time, we do not have an active session, so we are defaulting the driver to be the Playwright one.
The driver is then used here for collecting observations post tool usage. That will be broken for Mobile
There was a problem hiding this comment.
all tools would work, except the launch tool
| * @param _toolName - The tool name to check. | ||
| * @returns Always true for browser platform. | ||
| */ | ||
| isToolSupported(_toolName: string): boolean { |
There was a problem hiding this comment.
Why do we need this method? Aren't we gating with the isBrowserOnlyTool?
Having both is a bit confusing.. I personally think that the driver should dictate which tools it supports, but we can add that pattern later and keep the simpler isBrowserOnlyTool for now
| const errorInfo = classifyClickError(error); | ||
| if ( | ||
| errorInfo.code === ErrorCodes.MM_WAIT_TIMEOUT || | ||
| errorInfo.message.includes('visibility wait consumed entire budget') |
There was a problem hiding this comment.
This is dead code... if the error message has "timeout" then the error code will be MM_WAIT_TIMEOUT
…cp-core into add-device-mcp-support
2 participants
No description provided.