chore(analytics): drop saveDataRecording from Tokens util + sweep assets test mocks

[NicolasMassart]

Description

Removes the unused saveDataRecording?: boolean second argument from the trackEvent prop type in goToAddEvmToken and removeEvmToken. That parameter was a holdover from the legacy MetaMetrics API; useAnalytics's trackEvent never accepted a second argument. Sweeps the now-dead setSaveDataRecording: jest.fn().mockReturnThis() key from the two affected test builder mocks.

This is PR-A of 6 in the owner-scoped sequence finishing the legacy MetaMetrics migration (#26820). PRs A–E are parallel mock-sweeps; PR-F does the interface removal once all five merge.

Changelog

CHANGELOG entry: null

Related issues

Refs: #26820

Manual testing steps

N/A — test-only and type-signature cleanup; unit tests cover the changed files.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Type-signature and test-mock cleanup only; analytics call paths are unchanged and trackEvent already ignored the removed parameter.

Overview
Continues the legacy MetaMetrics cleanup (#26820) by aligning Assets token helpers and tests with useAnalytics’s single-argument trackEvent.

goToAddEvmToken and removeEvmToken no longer type trackEvent with an optional saveDataRecording second parameter—that API was never implemented on the hook. DeFiPositionsList.test.tsx and Tokens/index.test.tsx drop setSaveDataRecording from mocked createEventBuilder chains for the same reason.

No runtime behavior change; typings and test doubles only.

^{Reviewed by Cursor Bugbot for commit bf7b2a1. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
All 4 changed files contain only minor TypeScript interface/type signature changes and corresponding test mock updates:

1. goToAddEvmToken.ts and removeEvmToken.ts: Removed the optional saveDataRecording?: boolean parameter from the trackEvent function type in their respective Props interfaces. This is a type-only change with no runtime behavior impact.

2. Tokens/index.test.tsx and DeFiPositions/DeFiPositionsList.test.tsx: Removed setSaveDataRecording: jest.fn().mockReturnThis() from mock builder objects to align with the updated interface.

These changes:

• Do not affect any user-facing functionality
• Do not change any navigation flows
• Do not modify any controller logic
• Do not affect any E2E test paths
• Are purely TypeScript type cleanup (removing an unused optional parameter)

No E2E tests need to run for these changes as they have zero functional impact on any user flows.

Performance Test Selection:
The changes are purely TypeScript interface/type signature cleanup (removing an optional parameter from trackEvent function types) with no runtime behavior changes. There is no impact on app performance, rendering, or any measured performance flows.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

This PR continues the legacy MetaMetrics migration cleanup by removing an unused saveDataRecording?: boolean second parameter from trackEvent prop typings in Tokens utilities, and updating affected unit-test event-builder mocks accordingly.

Changes:

• Simplifies trackEvent prop types in goToAddEvmToken and removeEvmToken to accept only AnalyticsTrackingEvent.
• Removes now-dead setSaveDataRecording from mocked createEventBuilder chains in the impacted tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
app/components/UI/Tokens/util/removeEvmToken.ts	Updates trackEvent prop type to a single-argument signature aligned with useAnalytics.
app/components/UI/Tokens/util/goToAddEvmToken.ts	Updates trackEvent prop type to a single-argument signature aligned with useAnalytics.
app/components/UI/Tokens/index.test.tsx	Removes setSaveDataRecording from the local analytics event-builder mock chain.
app/components/UI/DeFiPositions/DeFiPositionsList.test.tsx	Removes setSaveDataRecording from the local analytics event-builder mock chain.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.