chore(analytics): sweep saveDataRecording from identity + hardware-wallet test mocks

[NicolasMassart]

Description

Removes saveDataRecording: false from the inline build() return value in user-storage-controller-init.test.ts and setSaveDataRecording: jest.fn() from the builder mock in qrScannerUtils.test.ts. Both fields were stale after the legacy saveDataRecording chain was removed in N8 (#31256).

This is PR-C of 6 in the owner-scoped sequence finishing the legacy MetaMetrics migration (#26820). PRs A–E are parallel mock-sweeps; PR-F does the interface removal once all five merge.

Changelog

CHANGELOG entry: null

Related issues

Refs: #26820

Manual testing steps

N/A — test mock cleanup only; unit tests cover the changed files.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.