feat(activity-list): add ActivityListAccountImportTimeRow component a… - #31995
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
8cea28a to
4afc0ab
Compare
c419e4c to
65655a4
Compare
…nd related styles
…mproved date display in activity lists
…pproval token retrieval and enhance unlimited approval detection
abbb909 to
a5f1967
Compare
…w styles and icon integration
a5f1967 to
84da3a6
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 84da3a6. Configure here.
…sed on import time
Bugbot finding
|
…se onPress prop for navigation and streamline import time handling
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
⚡ Performance Test Results
❌ 4 tests failed · 20 tests · 1 device 📱 Devices tested (1)Android: Google Pixel 8 Pro (v14.0) ❌ Failed Tests (4)
@mm-perps-engineering-team
@metamask-mobile-platform
@metamask-onboarding-team
✅ Passed Tests (16)
Branch: |
|




Description
This PR updates asset/token details activity lists to render the redesigned
ActivityListItemRowwhen the activity redesign feature flag is enabled. It covers both EVM transactions rendered throughTransactionsand non-EVM transactions rendered throughMultichainTransactionsView, while keeping bridge activity and the legacy path unchanged when the flag is disabled.The implementation adds small asset-details adapter components that map existing transaction data into the unified activity item shape, preserve transaction-details navigation, and keep the legacy account-import marker behavior for EVM asset details. The activity redesign selector was moved to a shared feature flag selector module so route directories do not import from sibling routes.
Changelog
CHANGELOG entry: Updated asset details activity rows to use the redesigned activity list item when enabled
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-916
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk from a gated but user-facing activity path that changes list rendering, keys, and navigation wiring on EVM and multichain asset details; approval amount labeling affects how users read spending caps.
Overview
Asset details activity switches to the redesigned list when
tmcuActivityRedesignEnabledis true andlocationis asset details:TransactionsandMultichainTransactionsViewgroup items (pending/date headers), map txs through newAssetDetailsActivityListItem/MultichainAssetDetailsActivityListItemadapters, and keep legacyTransactionElement/MultichainTransactionListItem(including bridge rows) when the flag is off.Adds
ActivityListAccountImportTimeRow(EVM import-time marker + import tip navigation),ActivityListDateHeader, and centralizesformatActivityListDateHeader,getActivityValue,getActivityFromTo, andgetGroupedActivityListItemKeyinactivity-adapters(also consumed by homeActivityList).selectIsActivityRedesignEnabledmoves toselectors/featureFlagController/activityRedesign.Display fixes: unlimited token approvals show localized Unlimited (and skip fiat) via
isUnlimitedApprovalon adapters and row content; pending queued state uses design-system Clock icon; multichain TokenApprove maps to spending-cap activity.Reviewed by Cursor Bugbot for commit 46558cf. Bugbot is set up for automated code reviews on this repo. Configure here.