chore(analytics): sweep saveDataRecording from snaps test mocks

[NicolasMassart]

Description

Removes saveDataRecording: false from the inline build() return value in snap-controller-init.test.ts. The field was stale after the legacy saveDataRecording chain was removed in N8 (#31256).

This is PR-E of 6 in the owner-scoped sequence finishing the legacy MetaMetrics migration (#26820). PRs A–E are parallel mock-sweeps; PR-F does the interface removal once all five merge.

Changelog

CHANGELOG entry: null

Related issues

Refs: #26820

Manual testing steps

N/A — test mock cleanup only; unit tests cover the changed file.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Single-line test mock cleanup with no production code or analytics behavior changes.

Overview
Removes the obsolete saveDataRecording: false field from the AnalyticsEventBuilder.build() mock in snap-controller-init.test.ts, aligning the test stub with the current AnalyticsTrackingEvent shape after the legacy MetaMetrics saveDataRecording chain was dropped.

No runtime or snap-controller behavior changes—test mock cleanup only as part of the broader analytics migration (PR-E in a parallel mock-sweep sequence).

^{Reviewed by Cursor Bugbot for commit 4a3ea16. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Removes a stale saveDataRecording: false field from the mocked AnalyticsEventBuilder.build() return value in the Snap controller init unit test, aligning the test stub with the post-legacy MetaMetrics migration event shape.

Changes:

• Delete obsolete saveDataRecording property from the inline AnalyticsTrackingEvent mock in snap-controller-init.test.ts.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.