feat: [MUSD-1021] show musd back transactions in money activity cp-8.0.0

[Jwhiles]

Description

This PR updates the money activity list to show musdback transactions. It assumes a particular type for the transactions, which has not been confirmed by the accounts team yet. In the interest of speed, we plan to merge this and then make a cherry pick PR if the type needs to be changed.

Changelog

CHANGELOG entry: show cashback transactions in money activity

Related issues

Fixes: musd-1021

Manual testing steps

Feature: money activity
  Scenario: user has cashback transactions that land in their money account
    Given user has cashback transactions that land in their money account

    When user looks at the money activity
    Then they see the transactions

Screenshots/Recordings

Before

n/a

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches money activity merging, API transaction-type assumptions (METAMASK_CARD_CASHBACK), and navigation for activity details; wrong parsing or bucketing could mislabel deposits vs transfers, though changes are well tested.

Overview
Money activity now treats Accounts API data as card spends and cashback (mUSD back) instead of card-only rows. Parsing accepts METAMASK_CARD_CASHBACK, types use AccountsApiActivity with kind: 'card' | 'cashback', and list rows go through AccountsApiActivityItem with shared display helpers.

Filtering and merging move into useMoneyActivityItems: home and full activity views share the same buckets (cashback in Deposits, card spends in Transfers), mock QA data includes a sample cashback row, and merge logic dedupes by hash with stable sort tie-breaks.

Details UX replaces the card bottom sheet and confirmations CardTransactionDetails with MoneyApiActivityDetailsView on the existing card-details route (activity param). Copy branches for spend vs earned amounts and counterparty rows; the modal sheet route is removed.

Tests and copy follow the rename (useMoneyAccountApiActivity, parseAccountsApiActivity) and add coverage for cashback filtering and the new details screen.

^{Reviewed by Cursor Bugbot for commit 6e5b192. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[ffmcgee725]

Is it intentional to have both "cashback" and "musd_back" with the same message ?

[ffmcgee725]

card_details is replaced with api_activity_details, but CardTransactionDetails component (still registered in MainNavigator.js) continues to reference the old keys.

ex.: line 119

        title={strings('money.card_details.title')}

This will produce visible broken text in production if anyone navigates to the confirmations card-detail screen.

The test likely doesn't catch this because strings() is mocked.

[ffmcgee725]

We now only reference API_ACTIVITY_DETAILS_SHEET, so CARD_TRANSACTION_DETAILS_SHEET is dead code I believe ?

[ffmcgee725]

Is hardcoding to confirmed here intentional ?

[ffmcgee725]

Also noticed this PR silently reverses #31908 's navigation architecture
#31908 main UX contribution for card transactions was: replace the bottom sheet with a full-screen CardTransactionDetails view.

This reverses this unintentionally I believe.

After this PR: AccountsApiActivityItem → new bottom sheet (MoneyApiActivityDetailsSheet at Routes.MONEY.MODALS.API_ACTIVITY_DETAILS_SHEET)
This means the full-screen CardTransactionDetails screen from #31908 becomes orphaned, while remaining registered in MainNavigator.js but nothing navigates to it.

I believe this is an oversight. Either way it deserves explicit discussion since PR #31908 specifically moved to full-screen.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeMoney
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 88%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR is entirely focused on the Money/Card feature area. Key changes include:

1. Type refactoring: CardTransaction → AccountsApiActivity (discriminated union supporting card and cashback kinds), enabling cashback rewards to surface alongside card spends in the activity list.

2. New unified details view: MoneyApiActivityDetailsView replaces both CardTransactionDetails (deleted) and MoneyCardTransactionDetailsSheet (deleted), consolidating card spend and cashback detail screens into one full-screen view.

3. Navigation wiring: MainNavigator.js now routes Routes.MONEY.CARD_TRANSACTION_DETAILS to MoneyApiActivityDetailsView instead of the old CardTransactionDetails. The modal route CARD_TRANSACTION_DETAILS_SHEET was removed from MoneyModalStack.

4. Hook consolidation: useMoneyAccountCardTransactions → useMoneyAccountApiActivity; useMoneyActivityItems now returns bucketed data (MoneyActivityBuckets) instead of a flat list, with cashback items routed to the Deposits bucket and card spends to Transfers.

5. Component renames: CardActivityItem → AccountsApiActivityItem, cardItem → accountsApiItem.

6. Localization: New strings for cashback/mUSD back activity labels.

All changes are scoped to app/components/UI/Money/ and related navigation/routes. The SmokeMoney tag covers Card home, add funds, and ramps flows — exactly the area affected. No other feature areas (confirmations, swap, stake, network, accounts, identity) are impacted by these changes.

Performance Test Selection:
The changes are entirely within the Money/Card activity display layer — type refactoring, component renames, and a new details view. There are no changes to performance-sensitive paths like app launch, login, onboarding, asset loading, swap execution, or account list rendering. No performance test tags are warranted.

View GitHub Actions results

[Jwhiles]

Also noticed this PR silently reverses #31908 's navigation architecture #31908 main UX contribution for card transactions was: replace the bottom sheet with a full-screen CardTransactionDetails view.

This reverses this unintentionally I believe.

After this PR: AccountsApiActivityItem → new bottom sheet (MoneyApiActivityDetailsSheet at Routes.MONEY.MODALS.API_ACTIVITY_DETAILS_SHEET) This means the full-screen CardTransactionDetails screen from #31908 becomes orphaned, while remaining registered in MainNavigator.js but nothing navigates to it.

I believe this is an oversight. Either way it deserves explicit discussion since PR #31908 specifically moved to full-screen.

Looks like this happened when we merged master. I've now rebased again, and I think that the modals are now behaving as per your changes.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 94.89796% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.42%. Comparing base (4e34bc5) to head (6e5b192).
⚠️ Report is 67 commits behind head on main.

Files with missing lines	Patch %	Lines
...ctivityDetailsView/MoneyApiActivityDetailsView.tsx	90.00%	1 Missing and 3 partials ⚠️
app/components/UI/Money/utils/accountsApi.ts	95.23%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #32004      +/-   ##
==========================================
+ Coverage   83.37%   83.42%   +0.05%     
==========================================
  Files        5816     5834      +18     
  Lines      151922   152899     +977     
  Branches    35741    36125     +384     
==========================================
+ Hits       126662   127556     +894     
- Misses      16588    16597       +9     
- Partials     8672     8746      +74     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud